Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

ened
Copy link
Contributor

@ened ened commented Aug 20, 2019

Description

This simply activates a integration test for a newly added method (getApplicationSupportDirectory) on the Android side.

Also completes the test suite for all path_provider methods.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Note

This integration test will fail until this PR is merged. I'm surprised this didn't block anywhere?

@ened ened force-pushed the path_provider/integration_test branch from 8803465 to 2a3e4d4 Compare August 20, 2019 12:50
@ened
Copy link
Contributor Author

ened commented Aug 20, 2019

Not good yet, I noticed a few test are missing.

@ened ened changed the title [path_provider] Activate getApplicationSupportDirectory integration test [path_provider] Add missing tests Aug 20, 2019
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I'll migrate this by hand to the new FirebaseExtended/flutterfire repo

@ened
Copy link
Contributor Author

ened commented Aug 22, 2019

@collinjackson path_provider moves to FlutterFire?

@ened
Copy link
Contributor Author

ened commented Aug 22, 2019

@collinjackson please have another look, there are platform unit tests for iOS as well.

Also, a recent commit (a3f9ce7) showed a potential issue that is not matched in the integration tests.

@collinjackson collinjackson self-requested a review August 28, 2019 23:31
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, I'm not thrilled with the function pathProviderPrivate at the global scope... I kinda wish that we'd made this plugin be a class instead of a bunch of individual functions. Do you think it might make sense to do that as a breaking change?

In any case, I think we should call it something more descriptive like setMockPathProviderPlatform

@ened
Copy link
Contributor Author

ened commented Aug 29, 2019

I think the beauty of path_provider is the simplicity, thus would prefer to just add setMockPathProviderPlatform. Will update PR.

@ened
Copy link
Contributor Author

ened commented Aug 29, 2019

@collinjackson ok - updated.

I think you may be right regarding a PathProvider class, but I would prefer to merge this PR, then #1953, #1716, maybe #1570 (if we have tests), and I may have another PR (based on #966) in preparation which enables multiple storage directories (as commonly seen on older Android phones w/ SD card and internal storage).

After that, version 2.0.0 could take over all of that and provide it nicely in a class interface.
WDYT?

@collinjackson collinjackson merged commit 1bb42f5 into flutter:master Sep 4, 2019
noelmansour pushed a commit to snowble/plugins that referenced this pull request Nov 13, 2019
* Fix getApplicationSupportDirectory integration test
* Add missing unit tests
* setMockPathProviderPlatform
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
* Fix getApplicationSupportDirectory integration test
* Add missing unit tests
* setMockPathProviderPlatform
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
* Fix getApplicationSupportDirectory integration test
* Add missing unit tests
* setMockPathProviderPlatform
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants