-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[path_provider] Add missing tests #1990
[path_provider] Add missing tests #1990
Conversation
8803465
to
2a3e4d4
Compare
Not good yet, I noticed a few test are missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I'll migrate this by hand to the new FirebaseExtended/flutterfire repo
@collinjackson path_provider moves to FlutterFire? |
…_provider/integration_test
@collinjackson please have another look, there are platform unit tests for iOS as well. Also, a recent commit (a3f9ce7) showed a potential issue that is not matched in the integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again, I'm not thrilled with the function pathProviderPrivate
at the global scope... I kinda wish that we'd made this plugin be a class instead of a bunch of individual functions. Do you think it might make sense to do that as a breaking change?
In any case, I think we should call it something more descriptive like setMockPathProviderPlatform
I think the beauty of |
…_provider/integration_test
@collinjackson ok - updated. I think you may be right regarding a After that, version 2.0.0 could take over all of that and provide it nicely in a class interface. |
* Fix getApplicationSupportDirectory integration test * Add missing unit tests * setMockPathProviderPlatform
* Fix getApplicationSupportDirectory integration test * Add missing unit tests * setMockPathProviderPlatform
* Fix getApplicationSupportDirectory integration test * Add missing unit tests * setMockPathProviderPlatform
Description
This simply activates a integration test for a newly added method (getApplicationSupportDirectory) on the Android side.
Also completes the test suite for all path_provider methods.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Note
This integration test will fail until this PR is merged. I'm surprised this didn't block anywhere?