-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[google_maps_flutter] Add methods to programmatically show/hide marker's infowindow #2181
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
70d6b84
to
315003f
Compare
315003f
to
99b7724
Compare
Any updates on Merging this pull request ? |
99b7724
to
3801148
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for sending this PR. It overall looks great! I did a first round of review and left some comments.
We would also need tests before we can land this.
...ogle_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/MarkersController.java
Show resolved
Hide resolved
packages/google_maps_flutter/ios/Classes/GoogleMapMarkerController.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/ios/Classes/GoogleMapMarkerController.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/ios/Classes/GoogleMapMarkerController.m
Outdated
Show resolved
Hide resolved
Thanks for the review @cyanglaz, i've been busy lately but soon i'll get back to this |
3801148
to
e7fabb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the CHANGELOG and pubspec with a new version. Thanks!!
1e533d7
to
e3ec2c3
Compare
e3ec2c3
to
5de0c2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
I am able to show only one infowindow at a time. Is there a way to show all infowidnows? |
@SenseiBunny only one info window is displayed at a time as stated in the google documentation |
merci vraiment pour laide ,mon probleme est resolu |
Description
I needed to programmatically show marker's infowindow when a user tapped a polyline, so i've implemented those method and i'm currently using them and trying to maintain my repo current with this one.
I want a opinion on this implementation, because i don't think it's the optimal. I've tried to use a method channel for each
Marker
so i would be able to callmarker.showInfoWindow()
, but i can't create method channel's on the fly.Related Issues
flutter/flutter#29899
flutter/flutter#33481
flutter/flutter#19647
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?