Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Re-land v2 embedding support #2204

Merged
merged 3 commits into from
Oct 17, 2019
Merged

[url_launcher] Re-land v2 embedding support #2204

merged 3 commits into from
Oct 17, 2019

Conversation

mklim
Copy link
Contributor

@mklim mklim commented Oct 16, 2019

Description

This is identical to the original PR, except it correctly increments the Flutter SDK version to the latest stable and fixes some minor Java style nits.

Related Issues

Fixes flutter/flutter#41849

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mklim mklim requested a review from cyanglaz October 16, 2019 23:49
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mklim mklim merged commit 2951f84 into flutter:master Oct 17, 2019
@mklim mklim deleted the url_launcher_migration_take2 branch October 17, 2019 20:58
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
This is identical to the original PR, except it correctly increments the Flutter SDK version to the latest stable and fixes some minor Java style nits.
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
This is identical to the original PR, except it correctly increments the Flutter SDK version to the latest stable and fixes some minor Java style nits.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[url_launcher] Support the v2 Android embedder plugins API
3 participants