Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Adds macOS support #2342

Merged
merged 8 commits into from
Dec 6, 2019
Merged

[path_provider] Adds macOS support #2342

merged 8 commits into from
Dec 6, 2019

Conversation

franciscojma86
Copy link
Contributor

Description

Adds macOS support for path_provider, along with a macOS example.

Related Issues

Fixes flutter/flutter#41714

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@franciscojma86 franciscojma86 changed the title WIP [path_provider] Adds macOS support [path_provider] Adds macOS support Dec 4, 2019
@franciscojma86 franciscojma86 removed the WIP label Dec 4, 2019
@franciscojma86 franciscojma86 requested review from amirh and mklim December 4, 2019 18:38
mklim
mklim reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some kinds of tests. https://github.com/flutter/flutter/wiki/Tree-hygiene#overview

The implementation itself LG otherwise.

packages/path_provider/example/android/settings.gradle Outdated
include ":$name"
project(":$name").projectDir = pluginDirectory
}
if (pluginDirectory.exists()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the same Gradle/minimum flutter SDK issue as discussed on the connectivity PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/path_provider/example/macos/.gitignore Outdated
@@ -0,0 +1,6 @@
# Flutter-related
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extraneous gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/path_provider/path_provider_macos/LICENSE Outdated
@@ -0,0 +1,202 @@

Apache License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the same license issue as the shared_preferences PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/path_provider/path_provider_macos/pubspec.yaml

dependencies:
flutter:
sdk: flutter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also probably needs Flutter SDK bounds?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still an issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/path_provider/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 1.4.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This is adding a feature, so IMO it should be a MINOR upgrade instead of a PATCH one. In the other PRs incrementing this decimal place is still considered a "MINOR" upgrade by pub because of how it handles semver for packages that are below >1.0.0. It treats them as 0.MAJOR.MINOR+PATCH then.

https://semver.org/#spec-item-7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

mklim
mklim approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending one issue about pubspec.yaml.

Now that the example app the new macOS implementation it can be tested using the existing e2e suite.

packages/path_provider/path_provider_macos/android/.gitignore Outdated
@@ -0,0 +1,8 @@
*.iml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Extra .gitignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/path_provider/path_provider_macos/pubspec.yaml

dependencies:
flutter:
sdk: flutter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still an issue.

@franciscojma86 franciscojma86 merged commit 88793e6 into flutter:master Dec 6, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@franciscojma86
[path_provider] Adds macOS support (flutter#2342)
8b28b90
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@franciscojma86
[path_provider] Adds macOS support (flutter#2342)
2622f7d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson Awaiting requested review from collinjackson

@amirh amirh Awaiting requested review from amirh

1 more reviewer

@mklim mklim mklim approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[path_provider] Add macOS support
3 participants
@franciscojma86 @mklim @googlebot