-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter]Add pinch to zoom for Android #2451
Conversation
Please, we need this! |
Thanks @FisherWL , we need this! for those needing to fix this and can't wait for the official version, just download @FisherWL repository,
|
Hi @FisherWL, Thanks for the contribution! For this solution, I think we would want this to be configurable. Most likely somewhere in WebViewController. It could then be a no-op on iOS. This change would also require tests. |
The pr will merged in which version? This pr is very important for android~ |
The ability to set something like "withZoom=true" and "useWideViewPort=true" is extremely important... Many sites need to have those settings enabled in order to work properly. |
I need this too |
@bparrishMines @amirh can we pick this change up ourselves if it requires testing and configurability? This is pretty critical functionality that makes |
Is there any progress up to now? |
Thanks for the submission! We’re currently working through a large backlog of PRs, and this is not ready for review and landing as is (due to lack of configurability and tests, per earlier review comments). As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage anyone interested in this PR to vote for the corresponding issue. @FisherWL If you are interested in addressing the review comments before someone on the team has time to look into potentially adding the tests, please update the PR and let us know, and we can work on getting it reviewed. We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog. |
* some words improved * change switch color * magic logic to fix android import * did an important change in plugin flutter/plugins#2451
Closing, as this was obsoleted by #3325. |
Description
By using webview_flutter, pinch to zoom is enabled by default on ios, but not on android platform. This PR adds pinch to zoom for android, and hide the distracting +/- buttons..
Related Issues
flutter/flutter#48283
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?