Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter]Add pinch to zoom for Android #2451

Closed
wants to merge 1 commit into from

Conversation

FisherWL
Copy link

@FisherWL FisherWL commented Jan 8, 2020

Description

By using webview_flutter, pinch to zoom is enabled by default on ios, but not on android platform. This PR adds pinch to zoom for android, and hide the distracting +/- buttons..

Related Issues

flutter/flutter#48283

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cetorres
Copy link

cetorres commented Mar 5, 2020

@amirh Please approve this PR. This is a very important feature that's missing on Android. Thank you. And thank you @FisherWL for the great work!

@eltonmorais
Copy link

Please, we need this!

@otaviogrrd
Copy link

Thanks @FisherWL , we need this!

for those needing to fix this and can't wait for the official version, just download @FisherWL repository,
copy the folder webview_flutter located inside packages to your project root folder,
then on the pubspec.yaml add the dependecie as a folder like this:

  webview_flutter:
    path: ./webview_flutter

@bparrishMines
Copy link
Contributor

Hi @FisherWL,

Thanks for the contribution! For this solution, I think we would want this to be configurable. Most likely somewhere in WebViewController. It could then be a no-op on iOS.

This change would also require tests.

cc @cyanglaz @amirh

@cyanglaz cyanglaz added this to To be reviewed in Plugin PR Triage via automation Jul 22, 2020
@hongbiangoal
Copy link

The pr will merged in which version? This pr is very important for android~

@tal412
Copy link

tal412 commented Oct 2, 2020

The ability to set something like "withZoom=true" and "useWideViewPort=true" is extremely important... Many sites need to have those settings enabled in order to work properly.

@panudetjt
Copy link

panudetjt commented Oct 26, 2020

I need this too

@bkonyi
Copy link
Contributor

bkonyi commented Dec 18, 2020

@bparrishMines @amirh can we pick this change up ourselves if it requires testing and configurability? This is pretty critical functionality that makes WebView on Android useless in many circumstances.

@GreenHatHG
Copy link

Is there any progress up to now?
Will the official use the function of flutter_webview_plugin directly

@stuartmorgan stuartmorgan added the p: webview_flutter Edits files for a webview_flutter plugin label Jan 29, 2021
@stuartmorgan stuartmorgan removed the request for review from amirh February 16, 2021 21:20
@stuartmorgan
Copy link
Contributor

Thanks for the submission! We’re currently working through a large backlog of PRs, and this is not ready for review and landing as is (due to lack of configurability and tests, per earlier review comments). As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage anyone interested in this PR to vote for the corresponding issue.

@FisherWL If you are interested in addressing the review comments before someone on the team has time to look into potentially adding the tests, please update the PR and let us know, and we can work on getting it reviewed.

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

idealclover added a commit to WheretoSleepinNJU/NJU-Class-Shedule-Flutter that referenced this pull request Oct 2, 2021
* some words improved
* change switch color
* magic logic to fix android import
* did an important change in plugin flutter/plugins#2451
@stuartmorgan
Copy link
Contributor

Closing, as this was obsoleted by #3325.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: webview_flutter Edits files for a webview_flutter plugin platform-android
Projects
No open projects
Plugin PR Triage
  
To be reviewed