This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[image_picker] Added maxDuration property to pickVideo method #2643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, we can limit the length of recorded video to a certain number of seconds.
Replaced double with NSTimeInterval
…ndroid" This reverts commit 953f22a.
…s into image_picker_max_duration
…s into image_picker_max_duration
…_max_duration # Conflicts: # packages/image_picker/CHANGELOG.md # packages/image_picker/pubspec.yaml
Add XCTest and resolve conflicts.
13 tasks
@cyanglaz here is the new PR. |
This was referenced Apr 10, 2020
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
In some devices, the max duration doesn't work. Oneplus 6t I have tested didn't work. |
maxDuration doesn't apply on video picked from gallery on iPhone physical device. Is this a normal behavior or an issue ? |
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
maxDuration
property so a maximum recording duration can be set. Created a new pull request because the main branch changed on my repo (by my mistake).Related Issues
flutter/flutter#40035
flutter/flutter#2048
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?