Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

derTuca
Copy link
Contributor

@derTuca derTuca commented Apr 9, 2020

Description

Adds a maxDuration property so a maximum recording duration can be set. Created a new pull request because the main branch changed on my repo (by my mistake).

Related Issues

flutter/flutter#40035
flutter/flutter#2048

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

derTuca and others added 26 commits September 9, 2019 15:37
This way, we can limit the length of recorded video to a certain number of seconds.
Replaced double with NSTimeInterval
…_max_duration

# Conflicts:
#	packages/image_picker/CHANGELOG.md
#	packages/image_picker/pubspec.yaml
Add XCTest and resolve conflicts.
@derTuca
Copy link
Contributor Author

derTuca commented Apr 9, 2020

@cyanglaz here is the new PR.

@Renatinaveen
Copy link

In some devices, the max duration doesn't work. Oneplus 6t I have tested didn't work.

@loic-hamdi
Copy link

final PickedFile file = await _picker.getVideo(
      source: ImageSource.gallery,
      maxDuration: Duration(
        seconds: 4,
      ),
    );

maxDuration doesn't apply on video picked from gallery on iPhone physical device.
The PickedFile is not 4 seconds long.

Is this a normal behavior or an issue ?

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants