Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Apr 23, 2020

Description

Map plugins crashes when exiting app while using the FragmentActivity.
We are calling MapView.onDestroy at an inappropriate location which caused sone undefined behavior. MapView.onDestroy should only be called in the corresponding onDestroy method in from the activity or fragment. According to https://developers.google.com/android/reference/com/google/android/gms/maps/MapView#onDestroy%28%29 "You must call this method from the parent Activity/Fragment's corresponding method."

Also added some house keeping code to remove all the listeners when disposing.

Related Issues

Fixes flutter/flutter#55406

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cyanglaz cyanglaz requested a review from xster April 23, 2020 19:02
@xster
Copy link
Member

xster commented Apr 23, 2020

LGTM, thanks

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Apr 23, 2020

the crash seems to be something new related to google map sdk
https://stackoverflow.com/questions/61397027/androidruntime-fatal-exception-androidmapsapi-zoomtablemanager-java-lang-arra
b/154855417

@xster
Copy link
Member

xster commented Apr 23, 2020

ummm do we need a specific maps version constraint in our gradle in the meantime for our plugin?

@cyanglaz
Copy link
Contributor Author

@xster It seems to pass now (at least for my other gmap PR) Will see how this one goes.

@xster
Copy link
Member

xster commented Apr 23, 2020

Still LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google maps plugin crashes with FlutterJNI detached while detaching
3 participants