This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] fix crash and remove listeners #2704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Map plugins crashes when exiting app while using the
FragmentActivity
.We are calling
MapView.onDestroy
at an inappropriate location which caused sone undefined behavior.MapView.onDestroy
should only be called in the correspondingonDestroy
method in from the activity or fragment. According to https://developers.google.com/android/reference/com/google/android/gms/maps/MapView#onDestroy%28%29 "You must call this method from the parent Activity/Fragment's corresponding method."Also added some house keeping code to remove all the listeners when disposing.
Related Issues
Fixes flutter/flutter#55406
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?