This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[connectivity_platform_interface] Remove Platform asserts. #2715
+6
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even though the code path never hits web targets, having
dart:io
imports in the MethodChannel implementation in the platform_interface package breaks thepana
analysis of federated implementations for platforms where those imports are forbidden (like web), with something similar to this:This change removes the Platform check assert (if deemed critical, it should be added to the
connectivity
plugin, or maybe hidden behind a conditional import in this package).All current tests, both in connectivity_platform_interface and connectivity pass.
Related Issues
n/a
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?