Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

jiahaog
Copy link
Member

@jiahaog jiahaog commented Sep 12, 2020

A new version of the formatter or something might have rolled in, causing CI to break

A new version of the formatter or something might have rolled in, causing CI to break
@jiahaog
Copy link
Member Author

jiahaog commented Sep 12, 2020

Hmm, there's an issue where running pub global activate flutter_plugin_tools && pub global run flutter_plugin_tools format locally causes the block in packages/connectivity/connectivity/ios/Classes/FLTConnectivityPlugin.m to be formatted like:

default: {
  return @"unknown";
}

But the CI check expects the block to be formatted like:

default: { return @"unknown"; }

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiahaog jiahaog merged commit 97429bd into flutter:master Sep 12, 2020
@jiahaog jiahaog deleted the fix-formatting branch September 12, 2020 16:59
danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Sep 18, 2020
A new version of the formatter or something might have rolled in, causing CI to break
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
A new version of the formatter or something might have rolled in, causing CI to break
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
A new version of the formatter or something might have rolled in, causing CI to break
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants