Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Sep 14, 2020

Description

Overview of plugins scores on pub.dev.

Related Issues

First try was #2954 which was closed until bruno-garcia/badges.bar#2 got resolved.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@ditman
Copy link
Member

ditman commented Sep 17, 2020

Wow, this is so much fun! These badges look great!

IMO, I'd just leave the "pub score" badge to not clutter the table too much, and leave space for other columns (to list the available platforms per plugin, for example, similar to this one).

However I'm not a designer/product person, so don't consider this as an official review 😛

Thanks for the contribution!

@mit-mit
Copy link
Member

mit-mit commented Sep 17, 2020

LGTM from a Dart / pub.dev PoV.

@mit-mit
Copy link
Member

mit-mit commented Sep 17, 2020

We need to take this PR and deploy the fix before we take the present PR: bruno-garcia/badges.bar#7

@bruno-garcia
Copy link
Member Author

I've publish a new version (v0.1.1) to pub.dev and also rolled out live.
For packages loaded in the last hour will be returning the cached (wrong) badges.

I tested with this package to confirm the right values:
https://badges.bar/flutter_bloc/popularity
https://badges.bar/flutter_bloc/pub%20points

@bruno-garcia
Copy link
Member Author

bruno-garcia commented Sep 17, 2020

I'll wait for cache to expire before merging this.
Once it gets approved since it still has no explicit approval.

Thanks for catching and fixing that bug @mit-mit !

@mit-mit
Copy link
Member

mit-mit commented Sep 18, 2020

@csells any thoughts on whether we should show all three scores (as the PR currently does), or just one or two of them as mentioned in #3026 (comment) ? I personally think it looks OK with all three.

@csells
Copy link
Contributor

csells commented Sep 18, 2020

I don't have a strong opinion either way

@mit-mit
Copy link
Member

mit-mit commented Sep 18, 2020

@bruno-garcia did the caches flush, and we can merge this?

@bruno-garcia bruno-garcia merged commit 2d35643 into flutter:master Sep 18, 2020
@bruno-garcia bruno-garcia deleted the readme/badges branch September 18, 2020 15:39
@bruno-garcia
Copy link
Member Author

Thanks for approving this.
🎉 merged! Cached did clear yes, it's set for only 1 hour.

Looks awesome.

danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 1, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants