-
Notifications
You must be signed in to change notification settings - Fork 9.7k
badges for pub.dev scores #3026
Conversation
Wow, this is so much fun! These badges look great! IMO, I'd just leave the "pub score" badge to not clutter the table too much, and leave space for other columns (to list the available platforms per plugin, for example, similar to this one). However I'm not a designer/product person, so don't consider this as an official review 😛 Thanks for the contribution! |
LGTM from a Dart / pub.dev PoV. |
We need to take this PR and deploy the fix before we take the present PR: bruno-garcia/badges.bar#7 |
I've publish a new version (v0.1.1) to pub.dev and also rolled out live. I tested with this package to confirm the right values: |
I'll wait for cache to expire before merging this. Thanks for catching and fixing that bug @mit-mit ! |
@csells any thoughts on whether we should show all three scores (as the PR currently does), or just one or two of them as mentioned in #3026 (comment) ? I personally think it looks OK with all three. |
I don't have a strong opinion either way |
@bruno-garcia did the caches flush, and we can merge this? |
Thanks for approving this. Looks awesome. |
Description
Overview of plugins scores on pub.dev.
Related Issues
First try was #2954 which was closed until bruno-garcia/badges.bar#2 got resolved.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?