Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

stuartmorgan-g
Copy link
Contributor

Description

The plugin code uses strcmp, so should include cstring. Currently this
works only due to transitive includes that we can't count on being
present.

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

The plugin code uses strcmp, so should include cstring. Currently this
works only due to transitive includes that we can't count on being
present.
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd normally use <string.h> here as the code is more C-like than C++ like, but otherwise LGTM.

@stuartmorgan-g stuartmorgan-g merged commit 61799d7 into flutter:master Oct 21, 2020
@stuartmorgan-g stuartmorgan-g deleted the linux-url-launcher-cstring-include branch October 21, 2020 21:35
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
The plugin code uses strcmp, so should include cstring. Currently this
works only due to transitive includes that we can't count on being
present.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants