Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Move camera to camera/camera #3258

Merged
merged 5 commits into from Nov 10, 2020

Conversation

mvanbeusekom
Copy link
Contributor

Description

This pull request prepares the camera plugin for federation by simply moving all current logic into it's own "camera" folder. A suggested by @ditman in the PR #3253 (see #3253 (comment)).

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
    • I believe this is not necessary since this change doesn't require a release to pub.dev
  • I updated CHANGELOG.md to add a description of the change.
    • I believe this is not necessary since this change doesn't require a release to pub.dev
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Can you please update the pubspec.yaml of the plugin with a patch bump of the version, and the new homepage?

version: 0.5.8+15
homepage: https://github.com/flutter/plugins/tree/master/packages/camera/camera

Also add an entry to the changelog describing the change? Something like:

"Moved package to camera/camera subdir, to allow for federated implementations."

This way we can republish camera/camera to pub.dev, and others with in-flight PRs will understand why we did the move.

Thanks!!

@mvanbeusekom
Copy link
Contributor Author

@ditman, thank you for reviewing. I have processed your feedback and would appreciate it if you could give another review.

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to modify camera by camera/camera in this line:

https://github.com/flutter/plugins/blob/master/.cirrus.yml#L166

For tests to pass, otherwise this LGTM.

@mvanbeusekom mvanbeusekom merged commit 97d36e7 into flutter:master Nov 10, 2020
fesp pushed a commit to fesp/plugins that referenced this pull request Nov 11, 2020
* Move camera to camera/camera

* Fix relative path after move

* Rebased with master and update version

* Update homepage

* Skip XCTESTS for the camera/camera plugin
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
* Move camera to camera/camera

* Fix relative path after move

* Rebased with master and update version

* Update homepage

* Skip XCTESTS for the camera/camera plugin
@mvanbeusekom mvanbeusekom deleted the prepare_for_federation branch September 21, 2021 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants