Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

yogeshk25
Copy link

…ideo

Description

This PR introduces a new option to VideoPlayerOptions, which enables user to decide on whether user wants to keep playing video in the background or not.
This is a much requested feature, in many issues.

Related Issues

63836 - flutter/flutter#63836
63735 - flutter/flutter#63735
55673 - flutter/flutter#55673
48008 - flutter/flutter#48008
40722 - flutter/flutter#40722
32571 - flutter/flutter#32571

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla
Copy link

google-cla bot commented Dec 3, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 3, 2020
@yogeshk25
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Dec 3, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@cyanglaz
Copy link
Contributor

I'm going to close the PR because the CLA is not signed. Feel free to ping me when the CLA is signed and I'll re-open the PR. Or you can open a new PR after signing the CLA.

@cyanglaz cyanglaz closed this Jan 14, 2021
@dvasea1
Copy link

dvasea1 commented Jan 22, 2021

@yogeshk25 how to import this in my project?

@yogeshk25
Copy link
Author

@dvasea1 until this is merged, you can use, following to use functionality,

  video_player:
    git:
      url: https://github.com/Yogeshk25/plugins.git
      path: packages/video_player/video_player

YuheiNakasaka added a commit to YuheiNakasaka/flutter-plugins that referenced this pull request Feb 15, 2021
YuheiNakasaka added a commit to YuheiNakasaka/flutter-plugins that referenced this pull request Feb 15, 2021
YuheiNakasaka added a commit to YuheiNakasaka/flutter-plugins that referenced this pull request Feb 15, 2021
@IlyaMax
Copy link
Contributor

IlyaMax commented Aug 18, 2021

@yogeshk25 why can't you just sign it?

If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants