Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[quick_actions] Update "eponymous concept" link. #3305

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

happy-san
Copy link
Contributor

@happy-san happy-san commented Dec 7, 2020

Description

Umm, a measly link update.

Related Issues

--

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla
Copy link

google-cla bot commented Dec 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 7, 2020
@happy-san happy-san changed the title Update "eponymous concept" link. [integration_test] Update "eponymous concept" link. Dec 7, 2020
@happy-san
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 7, 2020
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor

Unfortunately this never landed, and now has a conflict. If you can update and resolve (it may just be the file move), we can get this landed.

#2851 is the same fix; whichever gets updated can be landed and the other closed.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Mar 24, 2021
13 tasks
@stuartmorgan-g stuartmorgan-g changed the title [integration_test] Update "eponymous concept" link. [quick_actions] Update "eponymous concept" link. Mar 24, 2021
@happy-san
Copy link
Contributor Author

Hey, @stuartmorgan do I rebase this against master?

@stuartmorgan-g
Copy link
Contributor

I'm re-running the failed CI jobs since they were network/server issues, then it should be good to land. Thanks for updating!

(Normally we'd do a version bump so we could publish, but I expect this plugin to have other updated published relatively soon so we can just pick it up then.)

@stuartmorgan-g
Copy link
Contributor

Re-run of Windows Plugins was successful, but LUCI doesn't update GitHub status still, so landing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants