-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Additional Firestore Query methods #369
Additional Firestore Query methods #369
Conversation
I've now successfully tested startAt/After endAt/Before, limit and multiple orderBys on Android. |
I was working more or less on the same improvements in parallel - I also drafted the Document versions of startAt/After and endAt/Before. Any chance to include them too? |
@docet85 You could either file a separate PR, or shoot a PR to my branch to have it included in this PR. Advantage of filing separate being that the Flutter team might like your implementation better. 😄 I thought about implementing the Document versions, but couldn't think of a synchronous way to do so, as it wants I could, however, see creating a special Query class that has something like a But I'm still getting the hang of this, so I could be way off the mark. |
@Skylled that's true. I have just realized the translation of Concerning the Anyhow terrific work - great to have the array version of orderBy! Get this PR merged. Let's keep in touch! Best |
Looks great, thanks! |
is there any example for startAt, startAfter ? I tried following code but getting error at startAfter
Error:
|
When this code was written, it was not yet possible to implement these methods using Now that #429 is out and flutter/flutter#13043 is long behind us, it may be worth creating new versions of the methods using |
* Extend orderBy to be used multiple times. * Implement startAt/After and endAt/Before * Implement `limit` method * Formatting fix * Fix missing parameter list and related tests * Formatting fixes * Pass start/end methods an array, not a list * Update CHANGELOG.md * Update pubspec.yaml
Fixes flutter/flutter#13613
Added features:
Query
can now have more than oneorderBy
field.startAt
,startAfter
,endAt
, andendBefore
supportlimit
supportcc @collinjackson @kroikie