This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] moved android iap unit tests #3732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
all the log says is Is there a way to make sure the tests did actually run? Maybe try to modify a test to intentionally fail and see if ci fails? |
|
@cyanglaz where is the location of the tests set for the CI? I couldn't really find it |
11 tasks
|
#3742 has landed. we should be able to rebase and run tests in this PR. |
|
Yes I tried to merge this with master yesterday, but this PR makes that close to impossible: #3744 |
renefloor
force-pushed
the
feature/move-android-test
branch
from
72be712 to
377d504
Compare
This reverts commit 8eade01.
mvanbeusekom
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 27, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved in_app_purchase unit tests.
As they were on the wrong place there was a misconception that they were missing.
Fixes flutter/flutter#78538 (as there were already quite some tests).
TextUtils and Logs had to be mocked as well to make the tests succeed in the new project.
Pre-launch Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.