Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Fix test driver name #3739

Merged
merged 7 commits into from
Mar 19, 2021
Merged

Conversation

ditman
Copy link
Member

@ditman ditman commented Mar 19, 2021

According to the docs, the test driver file must be called: test_driver/integration_test.dart.

This commit fixes the web plugins that don't follow the convention for their tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You should wait for #3738 to land and then rebase before landing this, since otherwise we'll be enabling tests on post-submit that have never run in presubmit.

@ditman
Copy link
Member Author

ditman commented Mar 19, 2021

Rebasing with #3738 now

@ditman ditman force-pushed the fix-test-driver-name branch from e2c5329 to c0e7094 Compare March 19, 2021 21:18
@ditman ditman requested a review from stuartmorgan-g March 19, 2021 22:32
@ditman
Copy link
Member Author

ditman commented Mar 19, 2021

PTAL @stuartmorgan, I had to do a small tweak to the run script for web tests that require an API key :/

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants