Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix analyzer issues #3863

Merged
merged 2 commits into from May 7, 2021
Merged

Conversation

stuartmorgan
Copy link
Contributor

  • Fixes new analyzer issues surfaced by recent Dart SDK fixes to sort order checking.
  • Enables --fatal-infos in the analyzer to match Flutter behavior.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
Copy link
Contributor Author

Landing on red since this is the fix for submit-queue being red.

@stuartmorgan stuartmorgan merged commit b2104b4 into flutter:master May 7, 2021
@stuartmorgan stuartmorgan deleted the analyzer-fixes branch May 7, 2021 18:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 7, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
* Make infos fatal when analyzing packages
* Fix import ordering for updated analysis
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants