Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Set SDK constraints to match Flutter beta #412

Merged
merged 4 commits into from
Mar 9, 2018

Conversation

mravn-google
Copy link
Contributor

Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure it's really a breaking change, since pre-beta users shouldn't get these new versions, but I'll leave that up to you.

@mravn-google
Copy link
Contributor Author

Thanks for the review. Not completely sure either, especially given that this is a "bootstrap" change. A minimally viable strategy for bumping the Flutter SDK requirement for a plugin should be to

  1. Bump at least the minor version number to allow for a bugfix release for an older Flutter SDK.
  2. Clearly document to plugin consumers that they may not be able to upgrade their plugin dependency to/past this new version without also making other changes.

Semver.org does not mention package resolution tooling, so I'll be conservative and consider item 2 above a breaking change.

@mravn-google mravn-google merged commit 4fabd71 into flutter:master Mar 9, 2018
@mravn-google mravn-google deleted the sdk_constraint branch March 9, 2018 12:50
jonasbark pushed a commit to jonasbark/plugins that referenced this pull request Mar 20, 2018
* commit 'a404fbfd4842b51b57bc0c6298604cf5674e2c02': (40 commits)
  Update README.md (flutter#430)
  Updated to 0.5.0 (flutter#428)
  AdSizes for AdMob banner ads (flutter#402)
  bump minor version and add changelog entry (flutter#427)
  add fetchProvidersForEmail wrapper (flutter#410)
  Incremental Build Script (flutter#422)
  add runtime permission requests for external storage and camera (flutter#424)
  Fix Dart 2 type error and deprecation (flutter#425)
  Fix a Dart 2 runtime cast failure in firebase_database test (flutter#419)
  Fixed deprecation warnings (flutter#420)
  Fix Dart 2 runtime error in the camera plugin (flutter#417)
  Always use the latest Flutter available (flutter#415)
  Spelling (flutter#411)
  Configure Flutter CI (flutter#383)
  Set SDK constraints to match Flutter beta (flutter#412)
  Remove Gradle artifacts from repo (flutter#414)
  Google maps plugin stub (flutter#405)
  Allow null document snapshot data when document does not exist (flutter#406)
  Fix new formatting errors (flutter#408)
  Fix url_launcher for iOS <10 (flutter#407)
  ...
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants