Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Fix Dart 2 runtime error in the camera plugin #417

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Fix Dart 2 runtime error in the camera plugin #417

merged 2 commits into from
Mar 12, 2018

Conversation

mraleph
Copy link
Member

@mraleph mraleph commented Mar 11, 2018

@mraleph mraleph requested a review from mravn-google March 11, 2018 11:13
@mraleph mraleph mentioned this pull request Mar 11, 2018
Closed
@mraleph mraleph merged commit 08d2c01 into flutter:master Mar 12, 2018
@mraleph mraleph deleted the fix-camera branch March 12, 2018 20:58
jonasbark pushed a commit to jonasbark/plugins that referenced this pull request Mar 20, 2018
Merge commit 'a404fbfd4842b51b57bc0c6298604cf5674e2c02' into joined
ad90445 
* commit 'a404fbfd4842b51b57bc0c6298604cf5674e2c02': (40 commits)
  Update README.md (flutter#430)
  Updated to 0.5.0 (flutter#428)
  AdSizes for AdMob banner ads (flutter#402)
  bump minor version and add changelog entry (flutter#427)
  add fetchProvidersForEmail wrapper (flutter#410)
  Incremental Build Script (flutter#422)
  add runtime permission requests for external storage and camera (flutter#424)
  Fix Dart 2 type error and deprecation (flutter#425)
  Fix a Dart 2 runtime cast failure in firebase_database test (flutter#419)
  Fixed deprecation warnings (flutter#420)
  Fix Dart 2 runtime error in the camera plugin (flutter#417)
  Always use the latest Flutter available (flutter#415)
  Spelling (flutter#411)
  Configure Flutter CI (flutter#383)
  Set SDK constraints to match Flutter beta (flutter#412)
  Remove Gradle artifacts from repo (flutter#414)
  Google maps plugin stub (flutter#405)
  Allow null document snapshot data when document does not exist (flutter#406)
  Fix new formatting errors (flutter#408)
  Fix url_launcher for iOS <10 (flutter#407)
  ...
@kashifmin
Copy link

kashifmin commented Mar 25, 2018 •
edited
Loading

@mraleph , This still doesn't fix the issue:

E/flutter (24961): [ERROR:topaz/lib/tonic/logging/dart_error.cc(16)] Unhandled exception:
E/flutter (24961): type '_InternalLinkedHashMap' is not a subtype of type 'Map<String, dynamic>' in type cast where
E/flutter (24961):   _InternalLinkedHashMap is from dart:collection
E/flutter (24961):   Map is from dart:core
E/flutter (24961):   String is from dart:core
E/flutter (24961): 
E/flutter (24961): #0      Object._as (dart:core/object_patch.dart)
E/flutter (24961): #1      _CastListBase.[] (dart:_internal/cast.dart:99:46)
E/flutter (24961): #2      __CastIterableBase&ListMixin^#T0&#T1^#T1.elementAt (dart:_internal/list.dart:60:33)
E/flutter (24961): #3      MappedListIterable.elementAt (dart:_internal/iterable.dart:414:40)
E/flutter (24961): #4      ListIterable.toList (dart:_internal/iterable.dart:219:19)
E/flutter (24961): #5      availableCameras (package:camera/camera.dart:50:8)
E/flutter (24961): <asynchronous suspension>

Version details

Flutter 0.1.5 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 3ea4d06340 (4 weeks ago) • 2018-02-22 11:12:39 -0800
Engine • revision ead227f118
Tools • Dart 2.0.0-dev.28.0.flutter-0b4f01f759
camera: 0.1.1

@mravn-google mravn-google mentioned this pull request Mar 25, 2018
Merged
@MichaelSowah
Copy link

@mraleph I think this fix is on the master branch...switch to master channel and see if it works

@jonahwilliams jonahwilliams mentioned this pull request Nov 27, 2018
Closed
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
@mraleph
Fix Dart 2 runtime error in the camera plugin (flutter#417)
b3ae463 
* Fix Dart 2 runtime error in the camera plugin
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mravn-google mravn-google mravn-google approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mraleph @kashifmin @MichaelSowah @mravn-google @googlebot