Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Add CameraOptions used to constrain the camera audio and video #4164

Merged
merged 11 commits into from Jul 19, 2021
Merged

[camera_web] Add CameraOptions used to constrain the camera audio and video #4164

merged 11 commits into from Jul 19, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Jul 19, 2021 •
edited

Adds CameraOptions, used to constrain the camera audio and video, to camera_web plugin.

These options represent web MediaStreamConstraints and can be used to request the browser for media streams with audio and video tracks containing the requested types of media.

Part of flutter/flutter#45297

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Jul 19, 2021
@bselwe
Copy link
Contributor Author

bselwe commented Jul 19, 2021

@ditman @felangel @orestesgaolin

@bselwe bselwe changed the title [camera] Add camera options used to constrain the camera audio and video [camera] Add CameraOptions used to constrain the camera audio and video Jul 19, 2021
This was referenced Jul 19, 2021
Open
Closed
@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 19, 2021
@ditman

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 19, 2021
ditman
ditman approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jul 19, 2021
@fluttergithubbot fluttergithubbot merged commit e193daf into flutter:master Jul 19, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2021
@engine-flutter-autoroll
e193daf [camera] Add CameraOptions used to constrain the camera aud…
f7b6446 
…io and video (flutter/plugins#4164)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2021
@engine-flutter-autoroll
e193daf [camera] Add CameraOptions used to constrain the camera aud…
2f3bf07 
…io and video (flutter/plugins#4164) (#86673)
@bselwe bselwe mentioned this pull request Jul 20, 2021
Merged
11 tasks
@bselwe bselwe changed the title [camera] Add CameraOptions used to constrain the camera audio and video [camera_web] Add CameraOptions used to constrain the camera audio and video Jul 21, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@bselwe @fotiDim
[camera] Add CameraOptions used to constrain the camera audio and v…
283e843 
…ideo (flutter#4164)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bselwe @amantoux
[camera] Add CameraOptions used to constrain the camera audio and v…
3389723 
…ideo (flutter#4164)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

@felangel felangel felangel approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes p: camera platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@bselwe @ditman @felangel @fluttergithubbot