Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Add support for a flash mode #4222

Merged
merged 8 commits into from
Aug 9, 2021
Merged

[camera_web] Add support for a flash mode #4222

merged 8 commits into from
Aug 9, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Aug 9, 2021

Adds support for a flash mode to the web camera platform.

  • Added setFlashMode to Camera.
    • Saves the flash mode in the camera.
    • Enables the torch mode video constraint if the flash mode is torch (otherwise disables).
    • Throws a CameraWebException if the torch mode is not supported in the current browser or the camera has not been initialized or started.
  • The camera stream can now be accessed through the Camera.stream property.
  • Updated takePicture in Camera.
    • Enables the torch mode video constraint when taking a picture if the flash mode is either auto or always.
  • Added setFlashMode implementation to the camera plugin.
    • Calls setFlashMode on the camera with the given id.

Part of flutter/flutter#45297.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe
Copy link
Contributor Author

bselwe commented Aug 9, 2021

@ditman @felangel

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

Comment on lines +135 to +136
final shouldEnableTorchMode =
flashMode == FlashMode.auto || flashMode == FlashMode.always;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to be slightly odd behavior, but I'm not sure how this can be implemented, other than the highly experimental fillLightMode constraint.

Can we add a comment around here explaining why takePicture does slightly different things than setFlashMode? Somebody tracing this will see:

setFlashMode set to auto (explicitly DOESN'T SET torchMode -> takePicture sets torchMode to true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will add a comment for that!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #4227.

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 9, 2021
@fluttergithubbot fluttergithubbot merged commit b9512b6 into flutter:master Aug 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: camera platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants