This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Fix and test for 'implements' pubspec entry #4242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
bparrishMines,
cyanglaz and
LHLL
as code owners
stuartmorgan-g
commented
Aug 15, 2021
| bool passing = _checkSectionOrder(pubspecLines, sectionOrder); | ||
| if (!passing) { | ||
| print('${indentation}Major sections should follow standard ' | ||
| printError('${indentation}Major sections should follow standard ' |
There was a problem hiding this comment.
Minor opportunistic cleanup; I think printError didn't exist yet when I wrote this code.
stuartmorgan-g
commented
Aug 15, 2021
| containsAllInOrder(<Matcher>[ | ||
| contains( | ||
| 'Found a "homepage" entry; only "repository" should be used.'), | ||
| ]), |
There was a problem hiding this comment.
These changes are opportunistic cleanup; I noticed when duplicating tests as a starting point that when I wrote these tests I copied from what I have since discovered is an anti-pattern: not checking the details of the output on failures, which means failure tests can pass for the wrong reasons. This commandError+output pattern is what I've been applying throughout the codebase as I find the older style.
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2021
ditman
reviewed
Aug 26, 2021
| @@ -2,7 +2,7 @@ name: camera_web | |||
| description: A Flutter plugin for getting information about and controlling the camera on Web. | |||
| repository: https://github.com/flutter/plugins/tree/master/packages/camera/camera_web | |||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 | |||
| version: 0.1.0 | |||
| version: 0.1.0+1 | |||
There was a problem hiding this comment.
implements was not added to this yaml, but the test doesn't seem to be failing in CI? /cc @stuartmorgan
There was a problem hiding this comment.
I accidentally put the new check in the section of the command that doesn't run for publish_to: none packages, so it didn't catch my mistake here. I'll fix that tomorrow.
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
The federated plugin spec calls for implementation packages to include an `implements` entry in the `plugins` section of the `pubspec.yaml` indicating what app-facing package it implements. Most of the described behaviors of the `flutter` tool aren't implemented yet, and the pub.dev features have `default_plugin` as a backstop, so we haven't noticed that they are mostly missing (or in one case, incorrect). To better future-proof the plugins, and to provide a better example to people looking at our plugins as examples of federation, this adds a CI check to make sure that we are correctly adding it, and fixes all of the missing/incorrect values it turned up. Fixes flutter/flutter#88222
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
The federated plugin spec calls for implementation packages to include an `implements` entry in the `plugins` section of the `pubspec.yaml` indicating what app-facing package it implements. Most of the described behaviors of the `flutter` tool aren't implemented yet, and the pub.dev features have `default_plugin` as a backstop, so we haven't noticed that they are mostly missing (or in one case, incorrect). To better future-proof the plugins, and to provide a better example to people looking at our plugins as examples of federation, this adds a CI check to make sure that we are correctly adding it, and fixes all of the missing/incorrect values it turned up. Fixes flutter/flutter#88222
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The federated plugin spec calls for implementation packages to include an
implementsentry in thepluginssection of thepubspec.yamlindicating what app-facing package it implements. Most of the described behaviors of thefluttertool aren't implemented yet, and the pub.dev features havedefault_pluginas a backstop, so we haven't noticed that they are mostly missing (or in one case, incorrect).To better future-proof the plugins, and to provide a better example to people looking at our plugins as examples of federation, this adds a CI check to make sure that we are correctly adding it, and fixes all of the missing/incorrect values it turned up.
Fixes flutter/flutter#88222
Pre-launch Checklist
dart format.)[shared_preferences]///).