Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Add Android & iOS implementations for pausing the camera preview #4258

Merged
merged 7 commits into from Aug 27, 2021
Merged

[camera] Add Android & iOS implementations for pausing the camera preview #4258

merged 7 commits into from Aug 27, 2021

Conversation

BeMacized
Copy link
Member

@BeMacized BeMacized commented Aug 24, 2021 •
edited

This PR implements the pausePreview and resumePreview interface methods from the camera plugin's platform interface (added in #4191), to support the (un)pausing of the camera preview.

Related issues:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Aug 24, 2021
@BeMacized BeMacized mentioned this pull request Aug 24, 2021
Closed
11 tasks
mvanbeusekom
mvanbeusekom suggested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good in general but I feel it is missing some unit-tests.

packages/camera/camera/CHANGELOG.md Outdated Show resolved Hide resolved
...ges/camera/camera/android/src/main/java/io/flutter/plugins/camera/MethodCallHandlerImpl.java Show resolved Hide resolved
...ges/camera/camera/android/src/main/java/io/flutter/plugins/camera/MethodCallHandlerImpl.java Outdated Show resolved Hide resolved
packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java Outdated Show resolved Hide resolved
packages/camera/camera/ios/Classes/CameraPlugin.m Show resolved Hide resolved
packages/camera/camera/lib/src/camera_controller.dart Show resolved Hide resolved
@BeMacized @mvanbeusekom
Fixed punctuation
007ca56 
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
@BeMacized BeMacized marked this pull request as draft August 24, 2021 12:46
@BeMacized BeMacized marked this pull request as ready for review August 25, 2021 14:43
mvanbeusekom
mvanbeusekom approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 25, 2021
@fluttergithubbot fluttergithubbot merged commit 1f502e8 into flutter:master Aug 27, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2021
@engine-flutter-autoroll
1f502e8 [camera] Add Android & iOS implementations for pausing the ca…
db97cee 
…mera preview (flutter/plugins#4258)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Aug 27, 2021
@engine-flutter-autoroll
1f502e8 [camera] Add Android & iOS implementations for pausing the ca…
d74d8b5 
…mera preview (flutter/plugins#4258) (#89030)
@nt4f04uNd
Copy link
Member

Related issues should be closed I guess

@mvanbeusekom mvanbeusekom deleted the camera/preview-pause-impl-2 branch September 2, 2021 07:28
This was referenced Sep 2, 2021
Closed
Closed
@mvanbeusekom
Copy link
Contributor

@nt4f04uNd thanks for the reminder, I have closed the issues.

fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@BeMacized @fotiDim
[camera] Add Android & iOS implementations for pausing the camera pre…
4709ccb 
…view (flutter#4258)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@BeMacized @amantoux
[camera] Add Android & iOS implementations for pausing the camera pre…
c4a6d84 
…view (flutter#4258)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes p: camera platform-android platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@BeMacized @nt4f04uNd @mvanbeusekom @fluttergithubbot