Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ci] update wait-on-check version and set verbose to false #4262

Merged
merged 3 commits into from Aug 27, 2021

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 25, 2021

This commit has added a verbose property for wait-on-check which greatly reduce the output.
Each wait interval still produces an output so we still keep the 3 min interval for now so the output won't be too overwhelming.

This is tested in my personal repo here: https://github.com/cyanglaz/melos_test/runs/3414623441?check_suite_focus=true

Fixes flutter/flutter#85127

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Aug 25, 2021
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for following up on it!

@ditman
Copy link
Member

ditman commented Aug 27, 2021

Yeeessss, amazing!

stuartmorgan pushed a commit that referenced this pull request Aug 28, 2021
Relands #4262 as the white list has been updated to allow the newer wait-on-check version.
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
…utter#4289)

Relands flutter#4262 as the white list has been updated to allow the newer wait-on-check version.
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
…utter#4289)

Relands flutter#4262 as the white list has been updated to allow the newer wait-on-check version.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants