Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Add an initial device orientation event #4278

Merged
merged 2 commits into from
Aug 27, 2021
Merged

[camera_web] Add an initial device orientation event #4278

merged 2 commits into from
Aug 27, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Aug 27, 2021

Adds an initial device orientation event to the onDeviceOrientationChanged stream of the web camera platform. Fixes an issue where the camera preview has an incorrect aspect ratio until a device orientation is changed.

Part of flutter/flutter#45297.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@bselwe bselwe requested a review from bparrishMines as a code owner August 27, 2021 11:06
@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@bselwe
Copy link
Contributor Author

bselwe commented Aug 27, 2021

@ditman

@bselwe bselwe mentioned this pull request Aug 27, 2021
Open
ditman
ditman approved these changes Aug 27, 2021
View reviewed changes
packages/camera/camera_web/lib/src/camera_web.dart
// as soon as subscribed to this stream.
final initialOrientationEvent = html.Event("change");

return orientation.onChange.startWith(initialOrientationEvent).map(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startWith is a very nice solution for this. TIL. Cool!

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 27, 2021
@fluttergithubbot fluttergithubbot merged commit 39c1880 into flutter:master Aug 27, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2021
@engine-flutter-autoroll
39c1880 [camera_web] Add an initial device orientation event (flutter…
1e8d2e9 
…/plugins#4278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2021
@engine-flutter-autoroll
39c1880 [camera_web] Add an initial device orientation event (flutter…
b2abdbf 
…/plugins#4278)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@bselwe @fotiDim
[camera_web] Add an initial device orientation event (flutter#4278)
5b8b59b
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bselwe @amantoux
[camera_web] Add an initial device orientation event (flutter#4278)
5e5e9b8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

1 more reviewer

@ditman ditman ditman approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes p: camera platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bselwe @ditman @fluttergithubbot