This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Move custom analysis options into sub-packages #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the legacy analysis options were bulk-added to the repository to allow transitioning incrementally to the Flutter analysis options, they were added to top-level plugin groups. This makes it harder to migrate incrementally, and also means that when we add a new sub-package (e.g, a web or desktop implementation) it's automatically using the legacy options. This moves all the legacy option files into each individual package, and updates the allow list for the tool accordingly, so that migration can be done package by package.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
When the legacy analysis options were bulk-added to the repository to allow transitioning incrementally to the Flutter analysis options, they were added to top-level plugin groups. This makes it harder to migrate incrementally, and also means that when we add a new sub-package (e.g, a web or desktop implementation) it's automatically using the legacy options. This moves all the legacy option files into each individual package, and updates the allow list for the tool accordingly, so that migration can be done package by package.
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
When the legacy analysis options were bulk-added to the repository to allow transitioning incrementally to the Flutter analysis options, they were added to top-level plugin groups. This makes it harder to migrate incrementally, and also means that when we add a new sub-package (e.g, a web or desktop implementation) it's automatically using the legacy options. This moves all the legacy option files into each individual package, and updates the allow list for the tool accordingly, so that migration can be done package by package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the legacy analysis options were bulk-added to the repository to
allow transitioning incrementally to the Flutter analysis options, they
were added to top-level plugin groups. This makes it harder to migrate
incrementally, and also means that when we add a new sub-package (e.g, a
web or desktop implementation) it's automatically using the legacy
options.
This moves all the legacy option files into each individual package, and
updates the allow list for the tool accordingly, so that migration can
be done package by package.
No version change: Only affects development
No CHANGELOG change: no conceptual change that's interesting to document, since the analysis options for all plugins are still the same.
Part of flutter/flutter#76229
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).