This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Add marker API #481
Merged
Add marker API #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mravn-google
commented
Apr 9, 2018
mravn-google
commented
- Add marker API
- Simplified example pages
- Consolidated some Java code
sigurdm
approved these changes
Apr 10, 2018
| @@ -182,6 +198,10 @@ private static LatLngBounds toLatLngBounds(Object o) { | |||
| return new LatLngBounds(toLatLng(data.get(0)), toLatLng(data.get(1))); | |||
| } | |||
|
|
|||
| private static boolean toBoolean(Object o) { | |||
There was a problem hiding this comment.
Made use of toXxx(...) consistent across all types.
|
|
||
| void removeMarker(String markerId) { | ||
| final Marker marker = marker(markerId); | ||
| marker.remove(); |
There was a problem hiding this comment.
Do you also want to remove from markers?
There was a problem hiding this comment.
Yes, good catch. Done.
| return new BitmapDescriptor._(<dynamic>['defaultMarker', hue]); | ||
| } | ||
|
|
||
| static BitmapDescriptor fromAsset(String assetName, [String package]) { |
There was a problem hiding this comment.
Make package a named argument to align with AssetImage.
|
|
||
| part of google_mobile_maps; | ||
|
|
||
| class BitmapDescriptor { |
There was a problem hiding this comment.
Perhaps worthy of a short dart-doc as the name is very generic.
mravn-google
commented
Apr 10, 2018
| @@ -182,6 +198,10 @@ private static LatLngBounds toLatLngBounds(Object o) { | |||
| return new LatLngBounds(toLatLng(data.get(0)), toLatLng(data.get(1))); | |||
| } | |||
|
|
|||
| private static boolean toBoolean(Object o) { | |||
There was a problem hiding this comment.
Made use of toXxx(...) consistent across all types.
|
|
||
| void removeMarker(String markerId) { | ||
| final Marker marker = marker(markerId); | ||
| marker.remove(); |
There was a problem hiding this comment.
Yes, good catch. Done.
|
|
||
| part of google_mobile_maps; | ||
|
|
||
| class BitmapDescriptor { |
| return new BitmapDescriptor._(<dynamic>['defaultMarker', hue]); | ||
| } | ||
|
|
||
| static BitmapDescriptor fromAsset(String assetName, [String package]) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.