This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add support for updateMetadata #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
approved these changes
Apr 20, 2018
| FIRStorageReference *ref = [[FIRStorage storage].reference child:path]; | ||
| [ref updateMetadata:[self buildMetadataFromDictionary:metadataDictionary] | ||
| completion:^(FIRStorageMetadata *metadata, NSError *error) { | ||
| if (error != nil) { |
There was a problem hiding this comment.
[nit] Invert condition?
| }); | ||
|
|
||
| test('invokes correct method', () async { | ||
| await ref.getMetadata(); |
There was a problem hiding this comment.
This should call updateMetadata and try to change something.
| @@ -69,6 +69,15 @@ class StorageReference { | |||
| })); | |||
| } | |||
|
|
|||
| /// Updates the metadata associated with this [StorageReference]. | |||
There was a problem hiding this comment.
Please document what the method returns.
| }); | ||
|
|
||
| test('returns correct result', () async { | ||
| expect((await ref.getMetadata()).name, 'image.jpg'); |
There was a problem hiding this comment.
This should call updateMetadata and hopefully reflect that something was changed.
szakarias
force-pushed
the
FBStorageMetadata2
branch
from
8d0df85
to
d649089
Compare
szakarias
force-pushed
the
FBStorageMetadata2
branch
from
d649089
to
e16ec70
Compare
| /// Updates the metadata associated with this [StorageReference]. | ||
| /// | ||
| /// Returns a [Future] that will complete to the updated [StorageMetadata]. | ||
| Future<StorageMetadata> updateMetadata(StorageMetadata metadata) async { |
There was a problem hiding this comment.
This method ignores fields of metadata that cannot be set by the public StorageMetadata constructor.
slightfoot
pushed a commit
to slightfoot/plugins
that referenced
this pull request
Jun 5, 2018
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.