Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix for 2 bugs in the Video Player plugin #557

Merged
merged 2 commits into from
May 11, 2018
Merged

Fix for 2 bugs in the Video Player plugin #557

merged 2 commits into from
May 11, 2018

Conversation

quentinleguennec
Copy link
Contributor

  • Fixed a crash when eventSink is called on a null object in the native Android code.
  • Added a missing result to some native IOS method calls.

Ready for review.

@quentinleguennec quentinleguennec mentioned this pull request May 8, 2018
Merged
@quentinleguennec
Copy link
Contributor Author

quentinleguennec commented May 8, 2018 •
edited
Loading

I don't know what's the error with Travis Ci means.

Edit: I just updated with master and it passed now.

mravn-google
mravn-google approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mravn-google mravn-google merged commit a806c36 into flutter:master May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mravn-google mravn-google mravn-google approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quentinleguennec @mravn-google @googlebot