video_player: use exoplayer for better video compatibility #597

jonasbark · 2018-06-05T12:38:59Z

The default Android implementation using the MediaPlayer had different playback / codec problems on different devices. We mostly saw problems with a few Samsung phones.

By using the ExoPlayer library playback works fine on all devices we tested so far.

- remove unused imports - fix formatting

mravn-google

Thanks for the contribution, much appreciated. Can I ask you to address the white space issues? That would make it much easier to review the actual code changes. Thanks!

mravn-google · 2018-06-06T08:17:20Z

packages/video_player/android/build.gradle

+    dependencies {
+        implementation 'com.google.android.exoplayer:exoplayer-core:2.8.0'
+    }
+


Please this remove empty line.

mravn-google · 2018-06-06T08:17:36Z

packages/video_player/android/build.gradle

+        implementation 'com.google.android.exoplayer:exoplayer-core:2.8.0'
+    }
+
+}


... and add one at the end of the file.

mravn-google · 2018-06-06T08:18:55Z

...ges/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java

-        result.error("VideoError", "IOError when initializing video player " + e.toString(), null);
-      }
-    }
+    private static class VideoPlayer {


Please reduce indentation to two spaces to make the real diff stand out.

gradle line fixes

jonasbark · 2018-06-06T08:31:53Z

Done - Readability seems better now.

mravn-google · 2018-06-06T08:38:03Z

@jonasbark Thanks! The formatter CI job is still complaining about white space. The CONTRIBUTING.md file details how to get the Java formatter running on your machine.

pub global run flutter_plugin_tools format --plugins video_player

mravn-google

LGTM so far. I'll do some on-device testing and see if anything shows up.

mravn-google · 2018-06-06T08:40:11Z

packages/video_player/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.5.5
+
+* Android: use ExoPlayer instead of MediaPlayer for better video compatibility


"better video compatibility" => "better video format support"?

Please end line with a period.

mravn-google · 2018-06-06T08:49:11Z

...ges/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java

+        public void onLoadingChanged(final boolean isLoading) {
+
+          if (!isLoading) {
+


Please remove empty lines inside methods.

mravn-google · 2018-06-06T08:51:22Z

...ges/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java

-          new MediaPlayer.OnCompletionListener() {
-            @Override
-            public void onCompletion(MediaPlayer mediaPlayer) {
+      exoPlayer.addListener(new EventListener() {


Maybe subclass DefaultEventListener to avoid the empty methods?

Good idea - I implemented the changes based on your other suggestions as well and pushed the commit.

mravn-google · 2018-06-06T09:04:41Z

...ges/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java

@@ -337,6 +320,9 @@ private void onMethodCall(MethodCall call, Result result, long textureId, VideoP
        videoPlayers.remove(textureId);
        result.success(null);
        break;
+      case "orientation":


The Dart side does not call this method?

oops, that was a leftover. Will remove it.

mravn-google · 2018-06-06T09:16:53Z

...ges/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java

+      exoPlayer.setPlayWhenReady(true);
+
+      exoPlayer.addListener(
+          new EventListener() {


In case you missed my earlier comment here (we had a mid-air collision with your white space changes): please consider subclassing DefaultEventListener instead to avoid the empty methods.

- remove setVolume(0.0) call when loading is finished - adjust changelog

mravn-google · 2018-06-06T10:10:32Z

The example video takes a long time (order of 30 seconds) to show up, and when it does, it's several seconds into the playback. Are we starting the player correctly?

For the butterfly video, I get one of these on each loop:

I/ACodec  (18171): codec does not support config priority (err -2147483648)

sroddy · 2018-06-06T10:36:47Z

@mravn-google I've noticed that the actual code in the example is, I would say, "accidentally", working due to a series of possibly random conditions:

The listener that is registered in the initState is only tracking for play status changed
The _isPlaying property, even if set by the listener in the setState, is not used at all in the build method.
As video loading is performed in the initState method, there is no guarantee that the video is loaded by the time the platform part already updated the content and status of the video to a ready status.
I've noticed that if the above happens, the video is simply not shown until the very first rebuild of the the widget containing the VideoPlayer widget, which is, "accidentally" happening now only because the play status changes and triggers a rebuild due a setState that updates and unused variable

jonasbark · 2018-06-06T10:39:54Z

Indeed - I didn't catch that during testing. I pushed the necessary changes. Initialization should be sent already when the playback state changes to Player.STATE_READY. Previously it was sent only when the video has finished being fully loaded.

Nothing wrong on the Dart side imo.

Regarding the ACodec output. As it's marked as Log.INFO I wouldn't consider this an error.

sigurdm · 2018-06-06T11:13:03Z

@sroddy are you taking about the example in the README.md file?
It is intentional that a change in play-status will trigger a setState to rebuild with the video shown.
Maybe I don't fully understand your description. What would you change to make this work less 'accidentally'?

sroddy · 2018-06-06T12:15:11Z

@sigurdm

first fact that sounds strange to me is that you are calling a setState setting the _isPlaying variable in the state that you are not using inside the build function (in the build function you directly use _controller.value.isPlaying instead of that variable).
the second fact is that you are relying on the isPlaying changes to update the widget while I expect that the first frame of the video would be visible right after it has been loaded by the platform. In your example the video appears only when I tap on the play button, while I expected it to appear as soon as it is loaded.

jonasbark · 2018-06-06T12:20:14Z

@sroddy regarding 2.): with the fixed commits the example videos will start right away. No need to tap on a play button.

mravn-google · 2018-06-06T12:29:04Z

packages/video_player/pubspec.yaml

@@ -2,8 +2,8 @@ name: video_player
 description: Flutter plugin for displaying inline video with other Flutter
  widgets on Android and iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
+version: 0.5.5


I think we should make this a 0.6.0 to allow for patches to the version of the plugin that still uses MediaPlayer.

mravn-google · 2018-06-06T13:37:40Z

...ges/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java

      Map<String, Object> reply = new HashMap<>();
      reply.put("textureId", textureEntry.id());
      result.success(reply);
    }

-    @SuppressWarnings("deprecation")


Is there no ExoPlayer equivalent of the code below?

There actually is. I thought this was just a workaround to ensure proper audio playback on older Android devices. I readded this.

sigurdm · 2018-06-06T14:01:44Z

@sroddy I see your point now! The video will not show the first frame before it actually starts playing.

That should probably be fixed...

jonasbark · 2018-06-07T10:47:41Z

Does anyone have an idea how to approach this?
I'm not even sure if I'm really seeing any missing frames with the example application.

mravn-google

LGTM

mravn-google · 2018-06-07T11:25:00Z

...ges/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java

      Map<String, Object> reply = new HashMap<>();
      reply.put("textureId", textureEntry.id());
      result.success(reply);
    }

    @SuppressWarnings("deprecation")
-    private static void setAudioAttributes(MediaPlayer mediaPlayer) {
+    private static void setAudioAttributes(SimpleExoPlayer mediaPlayer) {


mediaPlayer => exoPlayer

mravn-google · 2018-06-07T11:26:08Z

@jonasbark The initialization issue is not really related to your changes, and we are working to fix it in a separate PR.

mravn-google · 2018-06-07T18:33:31Z

@jonasbark It appears we've accrued a merge conflict while waiting for CI to go green. Care to rebase and bump the version number?

…oplayer # Conflicts: # packages/video_player/CHANGELOG.md # packages/video_player/pubspec.yaml

jonasbark · 2018-06-07T19:03:30Z

Done

mravn-google · 2018-06-07T19:04:00Z

@jonasbark Thanks a lot. I'll land on green.

mravn-google · 2018-06-07T19:18:25Z

Published.

pyrossh · 2018-06-09T12:38:11Z

@jonasbark Great work. Just FYI .m3u8 format is not supported I've raised an issue for that. Will see if I can tackle it. flutter/flutter#18328
Also it would be great if we can handle/show the error gracefully. Right now it just throws random text into the layout.

uwejan · 2018-09-14T19:08:31Z

Hi, dose it support RTMP playback, it seems not i get the following exception though,

E/ExoPlayerImplInternal(28021): Source error.
E/ExoPlayerImplInternal(28021): com.google.android.exoplayer2.upstream.HttpDataSource$HttpDataSourceException: Unable to connect to 'rtmp url here'
E/ExoPlayerImplInternal(28021): 	at com.google.android.exoplayer2.upstream.DefaultHttpDataSource.open(DefaultHttpDataSource.java:194)
E/ExoPlayerImplInternal(28021): 	at com.google.android.exoplayer2.source.ExtractorMediaPeriod$ExtractingLoadable.load(ExtractorMediaPeriod.java:848)
E/ExoPlayerImplInternal(28021): 	at com.google.android.exoplayer2.upstream.Loader$LoadTask.run(Loader.java:317)
E/ExoPlayerImplInternal(28021): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
E/ExoPlayerImplInternal(28021): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
E/ExoPlayerImplInternal(28021): 	at java.lang.Thread.run(Thread.java:762)
E/ExoPlayerImplInternal(28021): Caused by: java.net.MalformedURLException: unknown protocol: rtmp
E/ExoPlayerImplInternal(28021): 	at java.net.URL.<init>(URL.java:596)
E/ExoPlayerImplInternal(28021): 	at java.net.URL.<init>(URL.java:486)
E/ExoPlayerImplInternal(28021): 	at java.net.URL.<init>(URL.java:435)
E/ExoPlayerImplInternal(28021): 	at com.google.android.exoplayer2.upstream.DefaultHttpDataSource.makeConnection(DefaultHttpDataSource.java:341)
E/ExoPlayerImplInternal(28021): 	at com.google.android.exoplayer2.upstream.DefaultHttpDataSource.open(DefaultHttpDataSource.java:192)

charafau · 2018-09-15T00:21:39Z

@uwejan afaik exoplayer2 supports rtmp via plugin: https://github.com/google/ExoPlayer/tree/dev-v2-r2.8.4/extensions/rtmp

so it's not supported ootb

pyrossh · 2018-09-17T05:03:49Z

@uwejan I have added m3u8 and dash support in this PR. https://github.com/flutter/plugins/pull/613/files
You can add rtmp by adding this implementation 'com.google.android.exoplayer:extension-rtmp:2.8.0' in the gradle file and checking if it works.

use exoplayer for better video compatibility

e5e853f

googlebot added the cla: yes label Jun 5, 2018

- fix playback of local files

ab7f288

- remove unused imports - fix formatting

jonasbark mentioned this pull request Jun 5, 2018

Create video plugin flutter/flutter#12848

Closed

mravn-google reviewed Jun 6, 2018

View reviewed changes

mravn-google self-assigned this Jun 6, 2018

four spaces => two spaces for indentation

4d553b6

gradle line fixes

formatting changed using

0dea347

pub global run flutter_plugin_tools format --plugins video_player

mravn-google reviewed Jun 6, 2018

View reviewed changes

- use DefaultEventListener for less method overriding

548f7e9

- remove setVolume(0.0) call when loading is finished - adjust changelog

send initialized state as early as the streaming begins

b4cb10f

mravn-google reviewed Jun 6, 2018

View reviewed changes

video_player: v0.5.5 => v0.6.0

630beb2

mravn-google reviewed Jun 6, 2018

View reviewed changes

video_player: readd setting audio attributes

e44c88c

video_player: remove unnecessary playWhenReady call

5ff8b45

mravn-google approved these changes Jun 7, 2018

View reviewed changes

video_player: rename mediaPlayer variable to exoPlayer

935d846

Merge commit '93a63cdec7f1d1745193aa13584f15f5e0016a0c' into video_ex…

fe4efbc

…oplayer # Conflicts: # packages/video_player/CHANGELOG.md # packages/video_player/pubspec.yaml

mravn-google merged commit eb17154 into flutter:master Jun 7, 2018

uwejan unassigned mravn-google Sep 14, 2018

brianegan mentioned this pull request Oct 9, 2018

RTMP Player fluttercommunity/chewie#59

Closed

		@@ -1,3 +1,7 @@
		## 0.5.5

		* Android: use ExoPlayer instead of MediaPlayer for better video compatibility

		public void onLoadingChanged(final boolean isLoading) {

		if (!isLoading) {

video_player: use exoplayer for better video compatibility #597

video_player: use exoplayer for better video compatibility #597

Conversation

jonasbark commented Jun 5, 2018

mravn-google left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonasbark commented Jun 6, 2018

mravn-google commented Jun 6, 2018

mravn-google left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mravn-google commented Jun 6, 2018

sroddy commented Jun 6, 2018 • edited Loading

jonasbark commented Jun 6, 2018

sigurdm commented Jun 6, 2018

sroddy commented Jun 6, 2018

jonasbark commented Jun 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sigurdm commented Jun 6, 2018

jonasbark commented Jun 7, 2018

mravn-google left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mravn-google commented Jun 7, 2018

mravn-google commented Jun 7, 2018

jonasbark commented Jun 7, 2018

mravn-google commented Jun 7, 2018

mravn-google commented Jun 7, 2018

pyrossh commented Jun 9, 2018 • edited Loading

uwejan commented Sep 14, 2018 • edited Loading

charafau commented Sep 15, 2018

pyrossh commented Sep 17, 2018

sroddy commented Jun 6, 2018 •

edited

Loading

pyrossh commented Jun 9, 2018 •

edited

Loading

uwejan commented Sep 14, 2018 •

edited

Loading