-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[camera] Add CameraX plugin for development #6178
Conversation
@@ -0,0 +1,3 @@ | |||
## 0.0.1 | |||
|
|||
* Create camera_android_camerax plugin for development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
* Create camera_android_camerax plugin for development. | |
* Creates camera_android_camerax plugin for development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And now that I think about it. This may change depending on whether we are publishing now or are waiting until the code is finished.
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 | ||
version: 0.0.1 | ||
homepage: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should include a publish_to: 'none'
. Are you intending on publishing the plugin through development to secure the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I didn't want to publish this. Should the version just be NEXT
then until it's published?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, setting it to NEXT
would be a good idea.
Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't get a chance to look at this earlier. I left some notes for things to clean up in a follow-up.
# Below is a list of people and organizations that have contributed | ||
# to the Flutter project. Names should be added to the list like so: | ||
# | ||
# Name/Organization <email address> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have Google Inc.
as a line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartmorgan Thanks for taking a look! I'm working on the first related PR and I'll make these changes there since I already encountered some of the issues you pointed out when writing it.
packages/camera/camera_android_camerax/lib/camera_android_camerax_platform_interface.dart
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/camera_android_camerax_platform_interface.dart
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/camera_android_camerax_method_channel.dart
Show resolved
Hide resolved
@@ -0,0 +1,73 @@ | |||
name: camera_android_camerax | |||
description: A new Flutter plugin project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should get fixed up before we forget.
|
||
environment: | ||
sdk: '>=2.14.0 <3.0.0' | ||
flutter: ">=2.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0 (or at least nothing earlier than 2.8, which is the earliest we have CI for).
# weight: 700 | ||
# | ||
# For details regarding fonts in packages, see | ||
# https://flutter.dev/custom-fonts/#from-packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should all be removed.
plugin_platform_interface: ^2.0.2 | ||
|
||
dev_dependencies: | ||
flutter_lints: ^2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove; we don't use this.
Adds plugin for development of the camera Android plugin implemented with CameraX.
This is to start flutter/flutter#107260.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.