Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Aug 3, 2022

Adds plugin for development of the camera Android plugin implemented with CameraX.

This is to start flutter/flutter#107260.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@camsim99 camsim99 changed the title Add CameraX plugin for development [camera] Add CameraX plugin for development Aug 5, 2022
@camsim99 camsim99 marked this pull request as ready for review August 5, 2022 22:59
@camsim99 camsim99 requested a review from bparrishMines as a code owner August 5, 2022 22:59
@camsim99 camsim99 requested a review from stuartmorgan-g August 8, 2022 17:05
@@ -0,0 +1,3 @@
## 0.0.1

* Create camera_android_camerax plugin for development.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
* Create camera_android_camerax plugin for development.
* Creates camera_android_camerax plugin for development.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now that I think about it. This may change depending on whether we are publishing now or are waiting until the code is finished.

issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.0.1
homepage:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should include a publish_to: 'none'. Are you intending on publishing the plugin through development to secure the name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't want to publish this. Should the version just be NEXT then until it's published?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, setting it to NEXT would be a good idea.

camsim99 and others added 4 commits August 9, 2022 14:08
Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2022
@auto-submit auto-submit bot merged commit 0134dff into flutter:main Aug 15, 2022
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't get a chance to look at this earlier. I left some notes for things to clean up in a follow-up.

# Below is a list of people and organizations that have contributed
# to the Flutter project. Names should be added to the list like so:
#
# Name/Organization <email address>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have Google Inc. as a line.

Copy link
Contributor Author

@camsim99 camsim99 Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan Thanks for taking a look! I'm working on the first related PR and I'll make these changes there since I already encountered some of the issues you pointed out when writing it.

@@ -0,0 +1,73 @@
name: camera_android_camerax
description: A new Flutter plugin project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get fixed up before we forget.


environment:
sdk: '>=2.14.0 <3.0.0'
flutter: ">=2.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0 (or at least nothing earlier than 2.8, which is the earliest we have CI for).

# weight: 700
#
# For details regarding fonts in packages, see
# https://flutter.dev/custom-fonts/#from-packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should all be removed.

plugin_platform_interface: ^2.0.2

dev_dependencies:
flutter_lints: ^2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove; we don't use this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants