This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Avoid joining thread causing ANR #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
changed the title
| @@ -677,11 +677,6 @@ public void stopBackgroundThread() { | |||
| if (backgroundHandlerThread != null) { | |||
| stoppingBackgroundHandlerThread = true; | |||
| backgroundHandlerThread.quitSafely(); | |||
| try { | |||
| backgroundHandlerThread.join(); | |||
There was a problem hiding this comment.
What does stoppingBackgroundHandlerThread do without this join? Presumably from the description quitSafely is asynchronous, so it looks like we're now setting it to true and then back to false within the same execution cycle.
There was a problem hiding this comment.
Oh you're right. I think I added that not knowing it was acting as a bandaid for the real problem!
stuartmorgan
approved these changes
Sep 2, 2022
| @@ -1,3 +1,7 @@ | |||
| ## 0.10.1 | |||
There was a problem hiding this comment.
Nit: this should be 0.10.1+2 since it's a bugfix to a <1.0 package.
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2022
|
Is it release yet? |
|
Yes, changes to our packages are generally published immediately. |
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses flutter/flutter#106493. Stops calling
joinon the backgroundHandlerThreadsince it is not needed for any thread synchronization andquitSafelyis used to ensure any outstanding messages are delivered.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.