This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Added functions to get the most recent images/videos from a user's gallery #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 19, 2018 14:07
…'s gallery on Android
…'s gallery on iOS
added 7 commits
August 15, 2018 22:26
…e_picker/get-most-recent
…rkos/plugins into image_picker/get-most-recent
…rkos/plugins into image_picker/get-most-recent
|
@kmorkos Is it possible for you to add tests to this patch? |
|
This probably wouldn't be too much work to land but stills a Dart-side unit test of the API that was added. |
|
Hi there, so sorry for the extremely delayed response. Unfortunately, I no longer have an iOS device to test with and I see there's some merge conflicts now. It would be great if somebody that can test this could take over from here and fix those conflicts and add the missing tests. Sorry again for very late response! |
|
@kmorkos Thanks for the contribution. I'm going to relentlessly close this PR since you are not able to continue working on this and it is a lot of code to maintain without tests. I encourage you to reopen it if you feel like to work on this again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing flutter/flutter#19563