Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

fredriks
Copy link
Contributor

@fredriks fredriks commented Aug 7, 2018

The platform is expecting NSURL where it got a string.

Fixes flutter/flutter#16309

The platform is expecting NSURL where it got a string.
@fredriks
Copy link
Contributor Author

fredriks commented Aug 19, 2018

@kwmt
Copy link
Contributor

kwmt commented Aug 23, 2018

I think this is a critical bug. I hope to merge the PR ASAP.

Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@bkonyi bkonyi merged commit 456dd37 into flutter:master Aug 23, 2018
@bkonyi
Copy link
Contributor

bkonyi commented Aug 23, 2018

@cbracken, this probably warrants a new version on pub. Looks like you have publish rights, could you look into it?

@fredriks fredriks deleted the firauth_photourl branch August 29, 2018 21:45
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
The platform is expecting NSURL where it got a string.
bazuka5801 added a commit to BazuMax/cordova-plugin-firebase-authentication that referenced this pull request Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants