This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update firebase_ml_vision for latest Firebase MLKit API #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
commented
Sep 27, 2018
| ## 0.2.0 | ||
|
|
||
| * **Breaking Change** Update TextDetector to TextRecognizer for android mlkit '17.0.0' and | ||
| firebase-ios-sdk '5.6.0'. |
bparrishMines
commented
Sep 27, 2018
|
|
||
| * **Breaking Change** Update TextDetector to TextRecognizer for android mlkit '17.0.0' and | ||
| firebase-ios-sdk '5.6.0'. | ||
| * Added CloudLabelDetector. |
There was a problem hiding this comment.
This is done in: #695
bparrishMines
commented
Sep 27, 2018
| @@ -55,7 +55,20 @@ public void onFailure(@NonNull Exception e) { | |||
|
|
|||
| private FirebaseVisionCloudDetectorOptions parseOptions(Map<String, Object> optionsData) { | |||
| final int maxResults = (int) optionsData.get("maxResults"); | |||
| final int modelType = (int) optionsData.get("modelType"); | |||
| final String modelTypeStr = (String) optionsData.get("modelType"); | |||
There was a problem hiding this comment.
I made a few changes with how to handle type so no changes to the API will break this.
bparrishMines
commented
Sep 27, 2018
| @@ -89,7 +89,7 @@ + (void)addData:(NSMutableDictionary *)addTo | |||
| } | |||
|
|
|||
| [addTo addEntriesFromDictionary:@{ | |||
| @"confidence" : confidence, | |||
| @"confidence" : confidence ? confidence : [NSNull null], | |||
There was a problem hiding this comment.
Fixed crash issue
bparrishMines
commented
Sep 27, 2018
| @@ -0,0 +1,36 @@ | |||
| // Copyright 2018 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
This is mostly a file rename vision_cloud_detector_options.dart -> cloud_detector_option.dart
bparrishMines
commented
Sep 27, 2018
| @@ -0,0 +1,153 @@ | |||
| // Copyright 2018 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
This is only a file rename text_detector.dart -> text_recognizer.dart with accompanied class rename
kroikie
approved these changes
Oct 5, 2018
bparrishMines
force-pushed
the
mlkit_text_dart
branch
2 times, most recently
from
96a0586
to
13de128
Compare
bparrishMines
force-pushed
the
mlkit_text_dart
branch
from
13de128
to
8d42b73
Compare
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the files name changes of
vision_cloud_detector_options.dartandtext_detector.dart:#803