Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update firebase_ml_vision for latest Firebase MLKit API #774

Merged
merged 23 commits into from
Oct 10, 2018

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Sep 7, 2018

For the files name changes of vision_cloud_detector_options.dart and text_detector.dart:
#803

## 0.2.0

* **Breaking Change** Update TextDetector to TextRecognizer for android mlkit '17.0.0' and
firebase-ios-sdk '5.6.0'.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done in PRs: #733 and #732


* **Breaking Change** Update TextDetector to TextRecognizer for android mlkit '17.0.0' and
firebase-ios-sdk '5.6.0'.
* Added CloudLabelDetector.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done in: #695

@@ -55,7 +55,20 @@ public void onFailure(@NonNull Exception e) {

private FirebaseVisionCloudDetectorOptions parseOptions(Map<String, Object> optionsData) {
final int maxResults = (int) optionsData.get("maxResults");
final int modelType = (int) optionsData.get("modelType");
final String modelTypeStr = (String) optionsData.get("modelType");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few changes with how to handle type so no changes to the API will break this.

@@ -89,7 +89,7 @@ + (void)addData:(NSMutableDictionary *)addTo
}

[addTo addEntriesFromDictionary:@{
@"confidence" : confidence,
@"confidence" : confidence ? confidence : [NSNull null],
Copy link
Contributor Author

@bparrishMines bparrishMines Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed crash issue

@@ -0,0 +1,36 @@
// Copyright 2018 The Chromium Authors. All rights reserved.
Copy link
Contributor Author

@bparrishMines bparrishMines Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly a file rename vision_cloud_detector_options.dart -> cloud_detector_option.dart

@@ -0,0 +1,153 @@
// Copyright 2018 The Chromium Authors. All rights reserved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a file rename text_detector.dart -> text_recognizer.dart with accompanied class rename

@bparrishMines bparrishMines force-pushed the mlkit_text_dart branch 2 times, most recently from 96a0586 to 13de128 Compare October 9, 2018 23:44
@bparrishMines bparrishMines merged commit 546ad6d into flutter:master Oct 10, 2018
@bparrishMines bparrishMines deleted the mlkit_text_dart branch October 23, 2018 19:12
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants