This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Update firebase_ml_vision for latest Firebase MLKit API #774
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
84cc43c
WIP start of branch
bparrishMines 5ea2157
Update dart code for TextRecognizer
bparrishMines 3ceda90
Update tests
bparrishMines d2849f9
write better tests
bparrishMines 9891e2c
Merge branch 'master' of github.com:flutter/plugins into mlkit_text_dart
bparrishMines 9030142
update version logs
bparrishMines c1e3c5d
Merge branch 'master' of github.com:flutter/plugins into mlkit_text_dart
bparrishMines 286b1cd
Update dart code for TextRecognizer
bparrishMines eddc986
Fix iOS TextRecognizer
bparrishMines 36e4ffa
Small changes to cloud label detector comments
bparrishMines db66943
Model type for cloud detectors use string
bparrishMines 94b4d00
Renamed file
bparrishMines 84a848b
Correct version
bparrishMines 3cb8da0
Formatting
bparrishMines b126b82
Filename change
bparrishMines ab866b9
README title name change
bparrishMines 7149767
Merge branch 'master' of github.com:flutter/plugins into mlkit_text_dart
bparrishMines 4f94667
Add detectInImage deprecation
bparrishMines 098e69d
Take out name
bparrishMines 58611f6
Update test to use processImage
bparrishMines e39222b
Merge branch 'master' of github.com:flutter/plugins into mlkit_text_dart
bparrishMines 70f87eb
Merge branch 'mlkit_text_dart' of github.com:bparrishMines/plugins in…
bparrishMines 8d42b73
Update iOS FaceDetector to lastest api
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
## 0.2.0 | ||
|
||
* **Breaking Change** Update TextDetector to TextRecognizer for android mlkit '17.0.0' and | ||
firebase-ios-sdk '5.6.0'. | ||
* Added CloudLabelDetector. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is done in: #695 |
||
|
||
## 0.1.2 | ||
|
||
* Fix example imports so that publishing will be warning-free. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,20 @@ public void onFailure(@NonNull Exception e) { | |
|
||
private FirebaseVisionCloudDetectorOptions parseOptions(Map<String, Object> optionsData) { | ||
final int maxResults = (int) optionsData.get("maxResults"); | ||
final int modelType = (int) optionsData.get("modelType"); | ||
final String modelTypeStr = (String) optionsData.get("modelType"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I made a few changes with how to handle type so no changes to the API will break this. |
||
|
||
final int modelType; | ||
switch (modelTypeStr) { | ||
case "stable": | ||
modelType = FirebaseVisionCloudDetectorOptions.STABLE_MODEL; | ||
break; | ||
case "latest": | ||
modelType = FirebaseVisionCloudDetectorOptions.LATEST_MODEL; | ||
break; | ||
default: | ||
throw new IllegalArgumentException(String.format("No type for model: %s", modelTypeStr)); | ||
} | ||
|
||
return new FirebaseVisionCloudDetectorOptions.Builder() | ||
.setMaxResults(maxResults) | ||
.setModelType(modelType) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done in PRs: #733 and #732