Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update example with interactable link #785

Merged
merged 6 commits into from
Oct 31, 2018
Merged

Update example with interactable link #785

merged 6 commits into from
Oct 31, 2018

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Sep 18, 2018 •
edited
Loading

This gives the example a clickable button to help test for flutter/flutter#21456

@bparrishMines bparrishMines changed the title Dynamo fix Update example with intractable link Sep 18, 2018
@bparrishMines bparrishMines changed the title Update example with intractable link Update example with interactable link Sep 18, 2018
mehmetf
mehmetf reviewed Sep 19, 2018
View reviewed changes
Copy link
Contributor

@mehmetf mehmetf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. However, it concerns me that resume only works in some of the cases. As I mentioned in the Issue log, we should follow up with Firebase team and clarify this.

@bparrishMines bparrishMines merged commit 18ab5d8 into flutter:master Oct 31, 2018
@bparrishMines bparrishMines deleted the dynamo_fix branch October 31, 2018 00:33
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
@bparrishMines @andreidiaconu
Update example with interactable link (flutter#785)
301a28d
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
@andreidiaconu
Revert "Update example with interactable link (flutter#785)"
bfbd8d8 
This reverts commit 301a28d.
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@bparrishMines
Update example with interactable link (flutter#785)
bea1c4f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mehmetf mehmetf mehmetf approved these changes

Assignees
No one assigned
Labels
cla: yes flutterfire
Projects
None yet
Milestone
No milestone
3 participants
@bparrishMines @mehmetf @googlebot