[google_maps_flutter]add support for map tapping

[RafaO]

Deliver the tap event in the map with the LatLng object where it happened.

Enables something like this:

      GoogleMap(
        onTap: (LatLng location) {
          showDialog(context: context, builder: (BuildContext context) {
            return AlertDialog(
              title: new Text("Map tapped!"),
              content: new Text("You tapped in " + location.latitude.toString() + ", " + location.longitude.toString()),
              actions: <Widget>[
                // usually buttons at the bottom of the dialog
                new FlatButton(
                  child: new Text("Close"),
                  onPressed: () {
                    Navigator.of(context).pop();
                  },
                ),
              ],
            );
          });
        },
      )

[nandymandy1]

I m not getting the idea of long tapped event on map to place marker on the tapped point listing or the Coordinates

[RafaO]

Hey @nandymandy1 ! This PR is just delivering the tap event. It has nothing to do with long tapped events.

[nandymandy1]

how can i get your codes as I m in tight development schedule and how can i get access to your repository???

[RafaO]

you can point to my fork like this in your pubspec.yaml:

  google_maps_flutter:
    git:
      url: git://github.com/RafaO/plugins.git
      ref: integration-branch
      path: packages/google_maps_flutter

But do it under your own risk! :)

[nandymandy1]

ontap listener ready?????

[nandymandy1]

can you show how to use it???

[RafaO]

I updated the PR description including an example of usage @nandymandy1 hope it is useful

[ghost]

can u please update this and re-publish it ?

[ebeem]

thanks for your contribution!!
I hope this PR gets merged soon, I believe getting location on tap/long-tap is a very essential feature

I am sorry that you're being asked this frequently, but I will appreciate it if you take some time to update your branch again as some APIs have changed.

also, I tried the snippet you posted, it looks like the listener is on the controller (not the google maps object itself) which seems an excellent decision in my point of view. here is a snippet that will add a marker and print tapped location, please consider updating your snippet so those who want to test your branch do not face any troubles

      mapController.onMapTapped.add((LatLng location) {
        print("tapped location ${location.latitude} ${location.longitude}");
        mapController.addMarker(new MarkerOptions(
          icon: BitmapDescriptor.defaultMarker,
          position: location,
        ));
      });

let me know once you update your fork so I update the snippet too, since the new API changes will break this snippet as well

[RafaO]

Hi @ebeem Thank you for your comment, I also hope this gets merged soon :)

I am not sure if I understood you completely.

I think this branch is already rebased to the newest changes on master. The controller is no longer used for listeners but the google map object itself. (It used to be the other way around) So I think the snippet is right. In fact, you can check the integration-branch of my fork which is still using the controller as you just described. Let me know if you still have a different mind :)

[ebeem]

@RafaO what branch are you actively updating?
it seems like the master is up-to-date, but the integration-branch is not
the master doesn't introduce the new listener onMapTap, while integration-branch does
but integration branch has some old APIs from old flutter google maps (23 days ago)

google_maps_flutter add support for map tapping 23 days ago

[RafaO]

@ebeem the branch I actively update is map-tap-support the integration branch is what I use privately in my projects with support for map tapping and this other PR #981 But didn't update it yet.

[ebeem]

tested, working great
Thanks

[iskakaushik]

@RafaO , thanks for the PR. We have now added support for on-device tests for google maps plugin. Please take a look at this file for an example test case. I will be happy to help you through any issue you run into while adding tests. Please add some relevant tests to your PR :-)

one suggestion for the test case would be to:

1. Create a map
2. Tap the map and make sure the map gets tapped.

Here is an example of how you would do it if it were a button:

final LiveWidgetController widgetController = LiveWidgetController(WidgetsBinding.instance);

  test('tapButton', () async {
    bool isPressed = false;

    await pumpWidget(Directionality(
      textDirection: TextDirection.ltr,
      child: Material(
        child: RaisedButton(
          onPressed: () {
            isPressed = true;
          },
          child: const Text(
            "Hello, World!",
            key: ValueKey<String>("text"),
          ),
        ),
      ),
    ));

    await widgetController.tap(find.byKey(const ValueKey<String>("text")));

    expect(isPressed, true);
  });

Thanks again!

[iskakaushik]

@RafaO , I can drive this PR to completion if you do not have the cycles/time to do it. Please allow changes to your branch. Follow the instructions at: https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork

[RafaO]

Hi @iskakaushik thanks for your feedback and help. The checkmark for allowing changes from maintainers is already activated (was also this way), I hope you are able to perform changes and of course feel free to do so.

So far I have this:

  test('testMapTap', () async {
    LatLng place;
    bool pressed = false;

    final ValueKey<String> mapKey = const ValueKey<String>("map");

    await pumpWidget(Directionality(
        textDirection: TextDirection.ltr,
        child: GoogleMap(
          initialCameraPosition: _kInitialCameraPosition,
          onMapTapped: (LatLng latLng) {
            place = latLng;
            pressed = true;
          },
        ),
        key: mapKey));

    await widgetController.tap(find.byKey(mapKey));

    expect(pressed, true);
  });

But is not working, neither with the boolean or with the place being not null.

I am also not sure what is the best way of running these tests because the device stays stuck at the end of tests.

Thank you.

[iskakaushik]

@RafaO , I looked into it. We do not support gestures on Platform Views yet. This is not a trivial problem because iOS does not let us synthesize gestures. As we don't have the infrastructure in place to effectively test this just yet. I filed an issue: flutter/flutter#30471

There are a couple of changes that I think will make this PR good to merge. Thanks again for this excellent contribution.

[RafaO]

Hi @iskakaushik thanks for taking a look and creating the issue. I reworked with your suggestions the PR. Let me know what you think.

[iskakaushik]

I think you misread my suggestion as onMapTap, I think just onTap is better api.

[iskakaushik]

[iskakaushik]

Will shortly publish 0.5.2 which should have this. Thanks for this, @RafaO 🥇

[iskakaushik]

#1447

[kjeremy]

Finally.