[testing_app] Add app functionality along with Widget Tests #476
Conversation
| void addRandomItems() { | ||
| for (var i = 0; i < 10; i += 2) { | ||
| favoritesList.add(Random().nextInt(50)); | ||
| } |
There was a problem hiding this comment.
This Screen is dependent on the Favorites Model for getting data. Since we are testing it directly, it was empty. So, I did something like this to add data into the model. Is this okay?
testing_app/test/widget_test.dart
Outdated
|
|
||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| import 'package:testing_app/main.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Counter increments smoke test', (WidgetTester tester) async { | ||
| testWidgets('Smoke test', (tester) async { |
There was a problem hiding this comment.
As we are already testing all the screens separately, I'm wondering if this file has become unnecessary. What are your thoughts on this?
There was a problem hiding this comment.
If it doesn't add to the narrative, it gets cut.
On the flipside, demonstrating how to test individual widgets standalone outside of the screens they are embedded in sounds like a useful demo...
There was a problem hiding this comment.
Either add a TODO or delete outright for the time being
There was a problem hiding this comment.
I've deleted it for now. I think we can do it in the month of August. I've noted it down.
| - Widget Tests: | ||
| - To run on physical device or emulator: | ||
| - Navigate to the project's root folder using command line. | ||
| - Run `flutter run test/<file_path>` |
There was a problem hiding this comment.
Do you think it would be a good idea to have simple instructions on how to run different types of tests? Will add more in the future along with tests if we are keeping it.
There was a problem hiding this comment.
We will probably need a mini tutorial here explaining how this sample demonstrates different styles of testing, and how to run each one. Something to do once we have all the testing styles in place.
There was a problem hiding this comment.
Sure. I'll add that to the list of things to be done once all of the testing styles are in place.
There was a problem hiding this comment.
Maybe add a TODO here?
| void addRandomItems() { | ||
| for (var i = 0; i < 10; i += 2) { | ||
| favoritesList.add(Random().nextInt(50)); | ||
| } |
| - Widget Tests: | ||
| - To run on physical device or emulator: | ||
| - Navigate to the project's root folder using command line. | ||
| - Run `flutter run test/<file_path>` |
There was a problem hiding this comment.
We will probably need a mini tutorial here explaining how this sample demonstrates different styles of testing, and how to run each one. Something to do once we have all the testing styles in place.
| home: HomePage(), | ||
| ), | ||
| ); | ||
| void main() { |
There was a problem hiding this comment.
nit: add new line between createHomeScreen and main. I feel like this should have been picked up by flutter format...
There was a problem hiding this comment.
I wonder why it didn't. I even tried it again right now. Finally ended up adding it manually. I think flutter format doesn't add new lines on its own.
There was a problem hiding this comment.
there is always something to add =)
testing_app/test/widget_test.dart
Outdated
|
|
||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| import 'package:testing_app/main.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Counter increments smoke test', (WidgetTester tester) async { | ||
| testWidgets('Smoke test', (tester) async { |
There was a problem hiding this comment.
If it doesn't add to the narrative, it gets cut.
On the flipside, demonstrating how to test individual widgets standalone outside of the screens they are embedded in sounds like a useful demo...
|
I've made the changes. You can go ahead and merge it when the build passes. |
|
Landed, thanks @abd99 |
I have added the app functionality and Widget Tests. Please let me know if anything else is needed here.
/cc @domesticmouse @RedBrogdon