Skip to content

Initial Macos support to Battery Plus #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 24, 2020
Merged

Initial Macos support to Battery Plus #2

merged 12 commits into from
Oct 24, 2020

Conversation

mhadaily
Copy link
Member

@mhadaily mhadaily commented Oct 2, 2020

@slightfoot slightfoot force-pushed the feature/battery_plus_macos branch 2 times, most recently from 67e28fe to 61290ab Compare October 2, 2020 17:55
slightfoot pushed a commit that referenced this pull request Oct 2, 2020
@jpnurmi
Add platform interface (#2)
e29b575 
* Move share_plus in a subdir
* Rename share.dart to share_plus.dart
* Fix integration_test dependency
* Add platform interface
slightfoot pushed a commit that referenced this pull request Oct 2, 2020
@mhadaily
support for web and add platform interface (#2)
263c253
slightfoot pushed a commit that referenced this pull request Oct 2, 2020
@miquelbeltran
Add ci files and issue templates (#2)
e0e9272 
* add ci files and issue templates

* project does not have android tests

Co-authored-by: Miquel Beltran <miquelbeltran@users.noreply.github.com>
@slightfoot slightfoot force-pushed the feature/battery_plus_macos branch from 61290ab to 0688a2e Compare October 2, 2020 19:13
orestesgaolin
orestesgaolin reviewed Oct 13, 2020
View reviewed changes
packages/battery_plus_macos/example/lib/main.dart Outdated
import 'package:flutter/services.dart';
import 'package:battery_plus_macos/battery_plus_macos.dart';

void main() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the example for the macos plugin should be stored in the battery_plus (main plugin) directory (similarly as is in case of connectivity)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes correct, this example will be removed.

@jpnurmi jpnurmi added the battery_plus Battery Plus Plugin label Oct 22, 2020
Nash0x7E2 and others added 7 commits October 22, 2020 18:47
@Nash0x7E2
remove example from platform impl
e777000 
Signed-off-by: Neevash Ramdial <mail@neevash.dev>
@Nash0x7E2
ignore .fmv
410da22 
Signed-off-by: Neevash Ramdial <mail@neevash.dev>
@Nash0x7E2
add macos package in pubspec yaml
c659d97 
Signed-off-by: Neevash Ramdial <mail@neevash.dev>
@jpnurmi
Merge remote-tracking branch 'origin/main' into feature/battery_plus_…
f126b5d 
…macos

Conflicts:
	.gitignore
	packages/battery_plus/pubspec.yaml
@jpnurmi
[battery_plus] Add example runner for macOS
0b0cbe1
@jpnurmi
[battery_plus] Add dummy .podspec for macOS
f4125d6 
Ref: #22
Ref: flutter/flutter#46618
@jpnurmi
[battery_plus_macos] Remove bogus test
0829ba9
@jpnurmi
Copy link
Member

jpnurmi commented Oct 24, 2020

I have merged with origin/main, resolved conflicts, and applied various smaller fixes to pass CI tests & analysis.

  • merged with origin/main

  • fixed up battery_plus/pubspec.yaml

    • removed flutter/plugin/platforms/macos/pluginClass
      (BatteryPlusMacosPlugin is in battery_plus_macos instead)
    • resolved conflicts in dependencies
      • changed battery_plus_macos from local relative path to ^0.1.0

  • cosmetic changes to sync with other plugins

    • battery_plus_macos/CHANGELOG.md
    • battery_plus_macos/LICENSE
    • battery_plus_macos/README.md

  • replaced battery_plus_macos/lib/battery_plus_macos.dart with a dummy file

  • fixed up battery_plus_macos/pubspec.yaml

    • fixed version, urls etc.
    • changed battery_plus_platform_interface from local relative path to ^0.1.0

  • generated macOS runner for the battery_plus example

  • added dummy battery_plus/macos/battery_plus.podspec (Allow plugins not to support macOS flutter/flutter#46618)

  • removed bogus battery_plus_macos/test

  • cosmetic changes

    • updated battery_plus_macos/LICENSE and CHANGELOG.md

@jpnurmi jpnurmi changed the title Initial Macos support Initial Macos support to Battery Plus Oct 24, 2020
@jpnurmi
Copy link
Member

jpnurmi commented Oct 24, 2020

State Level
image image

jpnurmi
jpnurmi approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💙 🎉

@jpnurmi jpnurmi merged commit 4568e23 into main Oct 24, 2020
@jpnurmi jpnurmi deleted the feature/battery_plus_macos branch October 24, 2020 11:51
@jpnurmi jpnurmi mentioned this pull request Oct 24, 2020
Merged
@stx stx mentioned this pull request Nov 14, 2020
Closed
jpnurmi added a commit that referenced this pull request Dec 13, 2020
@jpnurmi
[website] fix deployment attempt #2
892d4b1
@sureace sureace mentioned this pull request Jan 28, 2021
Closed
@sudheer-palaparambil sudheer-palaparambil mentioned this pull request Jun 4, 2021
Closed
@Jules369-ZM Jules369-ZM mentioned this pull request Jun 29, 2021
Closed
@chitgoks chitgoks mentioned this pull request Jul 21, 2021
Closed
@delegate-it delegate-it mentioned this pull request Mar 23, 2022
Closed
@jveryspace jveryspace mentioned this pull request May 9, 2022
Closed
@Anas35 Anas35 mentioned this pull request Sep 30, 2022
Closed
6 tasks
@kostadin24 kostadin24 mentioned this pull request Nov 24, 2022
Closed
7 tasks
@danallen88 danallen88 mentioned this pull request Feb 23, 2023
Closed
7 tasks
@animeshxd animeshxd mentioned this pull request Apr 25, 2023
Closed
7 tasks
@llyl llyl mentioned this pull request Dec 15, 2023
Closed
8 tasks
@enricocenteni enricocenteni mentioned this pull request Feb 1, 2024
Closed
8 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nash0x7E2 Nash0x7E2 Nash0x7E2 left review comments

@jpnurmi jpnurmi jpnurmi approved these changes

+1 more reviewer

@orestesgaolin orestesgaolin orestesgaolin left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Nash0x7E2 Nash0x7E2

Labels
battery_plus Battery Plus Plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhadaily @jpnurmi @orestesgaolin @Nash0x7E2