-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[share_plus] minSdkVersion 16 & graceful fallback #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The conflicts are due to #797. I will resolve them tonight (mainly formatting). Update: rebased |
Thanks! The original share method, could it be replaced by the one with the result? There's no difference except for the return type, which was |
Did not think about that - yeah, that would definitely simplify the API. The only problem I see is people not awaiting the "old" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments on namings.
What we are currently missing is updates to docs, which appear on Plus plugins website.
Would be good if you also modify https://github.com/fluttercommunity/plus_plugins/blob/main/docs/share_plus/usage.mdx to mention new methods and description about fallback on unsupported platforms.
...plus/share_plus/android/src/main/kotlin/dev/fluttercommunity/plus/share/MethodCallHandler.kt
Outdated
Show resolved
Hide resolved
...plus/share_plus/android/src/main/kotlin/dev/fluttercommunity/plus/share/MethodCallHandler.kt
Outdated
Show resolved
Hide resolved
Also added Will commit & push when EDIT: pushed |
@Coronon already touched on it a bit, but there's a difference in behavior between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this contribution!
Would like to wait for a review from Miguel as he was the person, who started reviewing this PR.
LGTM too, I will go ahead and merge & release |
I'm still getting this issue and android always return null in raw |
Description
minSdkVersion
back to 16 and dynamically determine support forshareWithResult
at runtimeshareWithResult
shareWithResult
Related Issues
Closes #789
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process.
pubspec.yaml
andCHANGELOG.md
.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?