Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to sanctuary-show for string representations #250

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Conversation

Avaq
Copy link
Member

@Avaq Avaq commented Jun 6, 2018

Closes #244

@Avaq Avaq requested a review from davidchambers June 6, 2018 08:11
@codecov-io
Copy link

codecov-io commented Jun 6, 2018

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #250   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          48     48           
  Lines        1196   1197    +1     
=====================================
+ Hits         1196   1197    +1
Impacted Files Coverage Δ
src/internal/fn.js 100% <100%> (ø) ⬆️
src/core.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf1540...e6e9801. Read the comment docs.

Copy link
Contributor

@davidchambers davidchambers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing Future(…) to Future (…).

@Avaq
Copy link
Member Author

Avaq commented Jun 7, 2018

changing Future(…) to Future (…).

I might at a later stage. I'm also considering switching to simple currying (#240), if and when I do, I'll change the function application style along with it.

@Avaq Avaq merged commit b0ad907 into master Jun 7, 2018
@Avaq Avaq deleted the avaq/show branch June 7, 2018 07:57
Avaq added a commit that referenced this pull request Jul 26, 2018
Breaking changes

- #224 Exceptions are now caught and rethrown in `fork`.
- #230 Many of the TypeScript type definitions that used `never` now use a
  generic instead.
- #238 When unsubscribing from a Future created by `hook`, the cancellation
  signal is no longer sent to the disposal Future.
- #266 Exported TypeScript interfaces have been renamed to avoid naming
  conflicts with exported values.

New features

- #250 Included interoperability with Sanctuary Show
- #261 Added a new function, `forkCatch`, which allows for exception recovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants