Rename TypeScript interfaces not to conflict with named values #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaq
commented
Jul 26, 2018
| @@ -342,16 +342,16 @@ declare module 'fluture' { | |||
|
|
|||
| } | |||
|
|
|||
| export var Future: Fluture | |||
| export var Future: FutureTypeRep | |||
| export default Future | |||
There was a problem hiding this comment.
It's all about this line here (346). This used to mean "export the Future interface as default", and now it means "export the Future value as default".
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 49 49
Lines 1211 1211
=====================================
Hits 1211 1211Continue to review full report at Codecov.
|
Avaq
added a commit
that referenced
this pull request
Jul 26, 2018
Breaking changes - #224 Exceptions are now caught and rethrown in `fork`. - #230 Many of the TypeScript type definitions that used `never` now use a generic instead. - #238 When unsubscribing from a Future created by `hook`, the cancellation signal is no longer sent to the disposal Future. - #266 Exported TypeScript interfaces have been renamed to avoid naming conflicts with exported values. New features - #250 Included interoperability with Sanctuary Show - #261 Added a new function, `forkCatch`, which allows for exception recovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259