Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forkCatch - fork with exception recovery #261

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Conversation

Avaq
Copy link
Member

@Avaq Avaq commented Jul 19, 2018

Closes #153

/cc @Beanow

@codecov-io
Copy link

Codecov Report

Merging #261 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #261   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          48     49    +1     
  Lines        1197   1211   +14     
=====================================
+ Hits         1197   1211   +14
Impacted Files Coverage Δ
src/dispatchers/fork-catch.js 100% <100%> (ø)
src/core.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26be7e2...87be4c0. Read the comment docs.

which can be very beneficial when the program is being used by multiple
clients. However, you also forego the certainty that your program will be in a
valid state after this happens. The more isolated the memory consumed by the
particular computation was, the more certain you will be that recovery is safe.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice explanation. :)

@Avaq Avaq merged commit 3078c78 into master Jul 25, 2018
@Avaq Avaq deleted the avaq/fork-catch branch July 25, 2018 10:29
Avaq added a commit that referenced this pull request Jul 26, 2018
Breaking changes

- #224 Exceptions are now caught and rethrown in `fork`.
- #230 Many of the TypeScript type definitions that used `never` now use a
  generic instead.
- #238 When unsubscribing from a Future created by `hook`, the cancellation
  signal is no longer sent to the disposal Future.
- #266 Exported TypeScript interfaces have been renamed to avoid naming
  conflicts with exported values.

New features

- #250 Included interoperability with Sanctuary Show
- #261 Added a new function, `forkCatch`, which allows for exception recovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants