Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

use go list so make test works on OSX #534

Merged
merged 2 commits into from
Apr 18, 2017
Merged

use go list so make test works on OSX #534

merged 2 commits into from
Apr 18, 2017

Conversation

paulbellamy
Copy link
Contributor

No description provided.

@squaremo
Copy link
Member

go list doesn't seem to find platform/kubernetes/testdata, which has tests to run.

@squaremo
Copy link
Member

It is .. quite strange .. there's nothing about that package that makes it special, except that it's only imported by other test files. I thought the build flag -tags 'test' might help, but doesn't appear to.

@paulbellamy
Copy link
Contributor Author

golang/go#14715 (comment)

Directory and file names that begin with "." or "_" are ignored
by the go tool, as are directories named "testdata".

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Paul

@paulbellamy paulbellamy merged commit a2de275 into master Apr 18, 2017
@paulbellamy paulbellamy deleted the better-test branch April 18, 2017 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants