Fix HelmChart valuesFile chart path restriction #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relu
force-pushed
the
fix-values-file-path-support
branch
from
3eb0d4d to
d397177
Compare
hiddeco
reviewed
Dec 16, 2020
relu
force-pushed
the
fix-values-file-path-support
branch
from
d397177 to
80b868b
Compare
hiddeco
changed the title
hiddeco
reviewed
Dec 16, 2020
hiddeco
added
bug
relu
force-pushed
the
fix-values-file-path-support
branch
2 times, most recently
from
fe46196 to
65d6930
Compare
hiddeco
approved these changes
Dec 17, 2020
As part of the feature implementation to support helm chart dependencies, the functionality for allowing values files overwriting from any location scoped to the same source was altered. This should fix the problem by allowing users to load files from any arbitrary location as long as it's in the context of the same source from where the helm chart itself is loaded. Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu
force-pushed
the
fix-values-file-path-support
branch
from
65d6930 to
a55c502
Compare
|
Thanks, didn't notice the typo! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
As part of the feature implementation to support helm chart
dependencies, the functionality for allowing values files overwriting
from any location scoped to the same source was altered. This should
fix the problem by allowing users to load files from any arbitrary
location as long as it's in the context of the same source from where
the helm chart itself is loaded.