Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unable to disable mach speed mode #739

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

lukecologne
Copy link
Member

@lukecologne lukecologne commented Sep 17, 2020

Summary of Changes

  • Fixes the issue after the 1.8.3 update where after switching to mach mode it was impossible to go back to normal mode

Example:
2020-09-18 11-39-21
This was from cold and dark, but it happens when spawned on the runway as well. Latest master

2020-09-18 11-47-27
With the fix

@tyler58546
Copy link
Member

The button works fine for me without this fix.

@NathanInnes
Copy link
Member

Works as intended.

@RikvanD1997
Copy link
Contributor

I had this issue yesterday after getting to cruise after the FMA switched to 'MACH' mode. I was not on the latest master build though, rather one from around 5 days ago.

@CaptainStraw
Copy link

I had the same problem with the default A320. I think it's not a problem with this mod but with the official code.

@lukecologne
Copy link
Member Author

Yes, pretty sure it is, but this fixes it. @tyler58546 are you sure? I know of at least two other people who have this bug, not including the ones that are in this thread

@DominikTV
Copy link

DominikTV commented Sep 18, 2020

I had this issue too after I used the Travel To / fasttravel option (was using the mod)

@lukecologne
Copy link
Member Author

See updated main post for a gif

@UncleClapton
Copy link
Contributor

Confirmed working

@UncleClapton UncleClapton merged commit 3ec2262 into flybywiresim:master Sep 18, 2020
@lukecologne lukecologne deleted the machFix branch September 18, 2020 15:18
@ErikNL80
Copy link

ErikNL80 commented Sep 19, 2020

I have tested in the latest master branch. Flying at FL280. Speed switched to Mach. Cannot get it back to knots. See the image below:
Naamloos

@lukecologne
Copy link
Member Author

lukecologne commented Sep 19, 2020

See this:
grafik
It might be intended that when it switches to mach automatically, you cannot go back to speed mode. Someone should confirm this though

@ErikNL80
Copy link

When descending, speed changes back to knots, and then it works again... But still, I am wondering if this is correct behaviour.

@adenflorian adenflorian added this to the v0.3.0 milestone Sep 26, 2020
@NathanInnes
Copy link
Member

NathanInnes commented Sep 28, 2020

This seems to be broken again. Can't switch from Mach to knots.

@lukecologne
Copy link
Member Author

On the ground? or while cruising? because the only thing I fixed was being unable to switch on the ground

@NathanInnes
Copy link
Member

NathanInnes commented Sep 28, 2020

Mid flight at cruise is the only one I tested. I will be on the ground shortly to see if it changes

@DesertRick13

This comment has been minimized.

@Benjozork
Copy link
Member

@DesertRick13 We cannot help you with 747 problems here.

@DesertRick13
Copy link

DesertRick13 commented Oct 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.