-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(failures): update with generator + images + inline bootstrap icon config #862
base: primary
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks a lot for the page @Valastiri
|
I'll look into this by tomorrow hopefully. For images I just don't have time to run the sim but I'll try and get the artifact to take some screenies. |
Thanks for the updates. Looking good so far ! Up to you. |
This does sound better I'll make that change in a bit. I'll batch the images and optimize them for each failure provided the ones you've sent are still valid / current. I haven't had a chance to update my sim or download the artifact so I'm counting on that heh. As soon as I've gotten the images this should be RTR |
Takeoff diagram will be WIP and may come at a later date. Hopefully can get it branded before a32nx PR is merged |
This PR is being prevented from merging because Review Required. Use the Approved label to run build validation and auto merge the PR. |
b79ca15
to
aadd21a
Compare
8b12e93
to
3619ece
Compare
Hey @Valastiri |
bigger icons |
This comment was marked as duplicate.
This comment was marked as duplicate.
can you add the button icon in a new section "Failure generator settings" below the section "Failure Pool Selection" |
Can you add in the section "Timed Failure Generator" |
Can you add at the end of the section "Altitude Failure Generator" Can you add at the end of the section "Speed Failure Generator" |
Can you modify this with the additional text (in bold) |
Can you modify this with the additional text (in bold) |
@Maverickwoe Hallo there! Icons + descriptions to follow later as I only had time to put in the text-based changes for now.
Done - within "info" admonition
Done - within "info" admonition
Where exactly am I adding this information?
Done |
Can you modify this with the additional text (in bold) "When configured in the "Take Off" arming, the timer will start once FLEX or TOGA thrust is set for the first time and the plane moves." Where exactly am I adding this information? this is a change in the TAKE OFF mode description in the section "Configuration Options" |
closes: #860
Summary
In support of A32NX PR:
Please reference issue above for more information.
/src
for original TAKEOFF icon combined in htmlAlso scrubbed the idea for a new page as everything was able to live on a single page and prevents a further nested directory.
Current Active List TODO
Location
Discord username (if different from GitHub): valastiri