Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Publish multi-architecture image #88

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Jan 9, 2023

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@welcome
Copy link

welcome bot commented Jan 9, 2023

Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line: - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: DCO Guide).

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #88 (1840d5e) into master (8a0429f) will decrease coverage by 1.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   69.54%   68.41%   -1.14%     
==========================================
  Files          31       31              
  Lines        1376     1656     +280     
==========================================
+ Hits          957     1133     +176     
- Misses        341      445     +104     
  Partials       78       78              
Flag Coverage Δ
unittests 68.41% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/manager/impl/artifact_data_store.go 60.00% <0.00%> (-8.00%) ⬇️
pkg/repositories/transformers/util.go 76.92% <0.00%> (-3.08%) ⬇️
pkg/repositories/gormimpl/list.go 65.38% <0.00%> (-3.04%) ⬇️
pkg/repositories/transformers/dataset.go 87.50% <0.00%> (-2.98%) ⬇️
pkg/manager/impl/reservation_manager.go 78.46% <0.00%> (-2.85%) ⬇️
pkg/repositories/gormimpl/reservation.go 83.33% <0.00%> (-2.64%) ⬇️
pkg/repositories/transformers/reservation.go 90.00% <0.00%> (-2.60%) ⬇️
pkg/config/config_flags.go 27.58% <0.00%> (-2.05%) ⬇️
pkg/runtime/configs/datacatalogconfig_flags.go 27.58% <0.00%> (-2.05%) ⬇️
pkg/manager/impl/dataset_manager.go 66.66% <0.00%> (-2.03%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jeevb jeevb marked this pull request as ready for review January 9, 2023 22:56
@jeevb jeevb requested a review from kumare3 as a code owner January 9, 2023 22:56
@wild-endeavor wild-endeavor merged commit faa86db into master Jan 9, 2023
@welcome
Copy link

welcome bot commented Jan 9, 2023

Congrats on merging your first pull request! 🎉

@jeevb jeevb deleted the jeev/multiarch-build branch January 9, 2023 22:58
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants